Replace Resources with Downloads as default page on dashboards#36756
Merged
mcbattirola merged 3 commits intomasterfrom Jan 17, 2024
Merged
Replace Resources with Downloads as default page on dashboards#36756mcbattirola merged 3 commits intomasterfrom
mcbattirola merged 3 commits intomasterfrom
Conversation
mcbattirola
requested review from
avatus and
kimlisa
and removed request for
avatus
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
mcbattirola
added
the
no-changelog
avatus
approved these changes
Jan 16, 2024
kimlisa
approved these changes
Jan 17, 2024
public-teleport-github-review-bot
Bot
removed request for
klizhentas and
zmb3
|
@mcbattirola See the table below for backport results.
|
This was referenced Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes:
Resourcestab on Dashboards with aDownloadstabDownloadsthe default route (when users visit the index page or click the Teleport logo)ossconfig, so it can be referenced here (follow up to remove the route frome: https://github.com/gravitational/teleport.e/pull/3165)Previously, as the unified resources tab was shown by default, users on dashboard could click it and see an error page (since the condition to not setup the unified resources page is
!cfg.isDashboard). Now, users will be on the downloads page by default.Note that I'm working on showing the Downloads page on Cloud (https://github.com/gravitational/cloud/issues/6667), but for Cloud, the Downloads page will not be in the top bar, but under the user menu, so only showing this new topbar link if
cfg.isDashboardis fine.