Supporting changes for download tab on Cloud#36399
Conversation
…tirola/download-tab-on-cloud
…ational/teleport into mcbattirola/download-tab-on-cloud
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
mcbattirola
added
the
no-changelog
| } | ||
|
|
||
| // hasSupportPageLinkAccess checks if the user | ||
| // has access to a Support external link in the side menu. |
There was a problem hiding this comment.
@avatus is in the middle of removing the side bar, was the dashboard view discussed with this refactor?
There was a problem hiding this comment.
This change is now in master btw: #36368
You may need to update how this is displayed @mcbattirola
There was a problem hiding this comment.
Thanks for pointing that out, I wasn't aware of the new topbar.
I've talked with Kenny, we'll be changing some stuff around:
- On dashboards, instead of
Resources, the first item in the top nav will be aDownloadstab (Replace Resources with Downloads as default page on dashboards #36756). - On Cloud, we'll move the link to under the user menu (accessed by clicking on the username, in the top right corner).
Since this PR doesn't introduce the top bar link, only changes the show condition, I think we can merge this and implement the changes listed above in a new PR.
…tirola/download-tab-on-cloud
…ational/teleport into mcbattirola/download-tab-on-cloud
…tirola/download-tab-on-cloud
public-teleport-github-review-bot
Bot
removed the request for review
from klizhentas
|
@mcbattirola See the table below for backport results.
|
* Add new flag to show/hide support link * Lint * Allow any user to list releases on cloud
4 participants
This PR includes two changes that support the issue https://github.com/gravitational/cloud/issues/6667:
hasSupportPageLinkAccess, since the support link was shown using the flaghasDownloadCenterListAccess, which is being modified, andhasDownloadCenterListAccessto always returntrueon cloud cluster.Contributes to https://github.com/gravitational/cloud/issues/6667