Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump actions/download-artifact from 3 to 4 #35845

Closed
wants to merge 1 commit into from
Closed

Bump actions/download-artifact from 3 to 4 #35845

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 18, 2023 •
edited
Loading

Bumps actions/download-artifact from 3 to 4.

Release notes

Sourced from actions/download-artifact's releases.

v4.0.0

What's Changed

The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.

For more information, see the @​actions/artifact documentation.

New Contributors

Full Changelog: actions/download-artifact@v3...v4.0.0

v3.0.2

v3.0.1

Commits
  • 7a1cd32 Merge pull request #246 from actions/v4-beta
  • 8f32874 licensed cache
  • b5ff844 Merge pull request #245 from actions/robherley/v4-documentation
  • f07a0f7 Update README.md
  • 7226129 update test workflow to use different artifact names for matrix
  • ada9446 update docs and bump @​actions/artifact
  • 7eafc8b Merge pull request #244 from actions/robherley/bump-toolkit
  • 3132d12 consume latest toolkit
  • 5be1d38 Merge pull request #243 from actions/robherley/v4-beta-updates
  • 465b526 consume latest @​actions/toolkit
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions no-changelog Indicates that a PR does not require a changelog entry labels Dec 18, 2023
@dependabot dependabot bot requested review from jentfoo and wadells December 18, 2023 17:50
@wadells wadells mentioned this pull request Dec 20, 2023
Merged
@wadells
Copy link
Contributor

wadells commented Dec 20, 2023 •
edited
Loading

I'd like to take #35953 first, as this should have updated another invocation (but it was missed, since it tracked master).

wadells
wadells approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@wadells wadells left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are breaking changes in v4: https://github.com/actions/toolkit/tree/main/packages/artifact#v2---whats-new

However, CI sufficiently tests this -- since OS-compatilbility are run on every PR and I have @jakule's permission to update e2e-test.yaml (it isn't used currently).

@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/download-artifact-4 branch from cd26b85 to ffb98e2 Compare December 20, 2023 23:41
@dependabot
Bump actions/download-artifact from 3 to 4
d15114c 
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/download-artifact-4 branch from ffb98e2 to d15114c Compare December 26, 2023 18:37
@wadells wadells added no-changelog Indicates that a PR does not require a changelog entry and removed no-changelog Indicates that a PR does not require a changelog entry labels Dec 26, 2023
@wadells wadells added this pull request to the merge queue Dec 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 26, 2023
@jentfoo jentfoo added this pull request to the merge queue Dec 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 26, 2023
@jentfoo
Copy link
Contributor

jentfoo commented Dec 26, 2023

I believe this update is causing issues with downloads in os compatibility tests: https://github.com/gravitational/teleport/actions/runs/7332492737/job/19966771105

@wadells
Copy link
Contributor

wadells commented Dec 26, 2023 •
edited
Loading

I believe this update is causing issues with downloads in os compatibility tests: https://github.com/gravitational/teleport/actions/runs/7332492737/job/19966771105

Yeah -- I saw that. Thankfully the merge queue caught it.

My RCA is:

download-artifacts@v4 needs artifacts uploaded via upload-artifacts@v4. upload-artifacts@v4 depends on a more recent glibc, which is incompatible with the current formulation of the os-compatiblity tests. See https://github.com/gravitational/teleport/actions/runs/7331880348/job/19965168124. This is a well known incompatiblity between recent NodeJS versions and older glibc:

actions/runner#2906

You'll see a handful of other actions held back in this file due to this issue as well.

There are two things that need to happen IMO:

  1. we need to resove the GHA + centos:7 conflict. I am experimenting with something like Refactor os-compatiblity-test CI #36052, where we limit use of centos:7 to the step that requires it. @jakule was looking at cross compilation.
  2. We need to fix our conditions so that os-compatiblity test runs when its workflow file is edited, regardless of it if is a dependabot change or not.

wadells
wadells suggested changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@wadells wadells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked pending addressing the issues in #35845 (comment)

This was referenced Dec 26, 2023
Closed
Draft
@wadells
Copy link
Contributor

wadells commented Dec 28, 2023

2. We need to fix our conditions so that os-compatiblity test runs when its workflow file is edited, regardless of it if is a dependabot change or not.

I've got a change to make sure CI catches dependabot failures before the merge queue:

#36105

@wadells
Copy link
Contributor

wadells commented Feb 13, 2024

Superseded by #38059

@wadells wadells closed this Feb 13, 2024
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 13, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/github_actions/actions/download-artifact-4 branch February 13, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wadells wadells wadells requested changes

@jakule jakule jakule approved these changes

@zmb3 zmb3 zmb3 approved these changes

@jentfoo jentfoo jentfoo approved these changes

@klizhentas klizhentas Awaiting requested review from klizhentas klizhentas is a code owner

@russjones russjones Awaiting requested review from russjones russjones is a code owner

@r0mant r0mant Awaiting requested review from r0mant r0mant is a code owner

@fheinecke fheinecke Awaiting requested review from fheinecke fheinecke is a code owner

@camscale camscale Awaiting requested review from camscale camscale is a code owner

@tcsc tcsc Awaiting requested review from tcsc tcsc is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file github-actions no-changelog Indicates that a PR does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wadells @jentfoo @zmb3 @jakule