Run OS compatiblity workflow on dependabot updates to the workflow #36105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadells
added
the
no-changelog
wadells
force-pushed
the
walt/os-compat-self-test
branch
from
9696a7a
to
bf9df30
Compare
We recently saw CI miss some failures because this workflow was skipped on a dependabot update that updates the workflow file itself. This also fixes GitHub actions to skip this build in the merge queue if it was skipped on CI.
wadells
force-pushed
the
walt/os-compat-self-test
branch
from
bf9df30
to
7faf32e
Compare
wadells
changed the title
This is no longer needed with dorny/paths filter targeting.
This was referenced Dec 28, 2023
wadells
requested review from
klizhentas,
russjones,
r0mant,
zmb3,
fheinecke,
camscale and
tcsc
as code owners
zmb3
approved these changes
Jan 2, 2024
fheinecke
requested changes
Jan 2, 2024
| filters: | | ||
| this-workflow: | ||
| - '.github/workflows/os-compatibility-test.yaml' | ||
| binary-sources: |
There was a problem hiding this comment.
Is this sufficient to capture the requirements? What about Rust files, shell scripts, and Docker files that are used in the build? Or e ref updates? Our build process is such a mess that I don't think that we can whitelist file extensions and still have the same level of coverage that trigger currently has.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently saw CI miss failures in #35848 because the workflow was skipped on a dependabot PR that updated the github actions workflow file itself.
This problem is systemic (a combo of #19745 and #31119), but I've chosen to solve it for only OS Comparability at the moment. Why?
This also fixes GitHub actions to skip the check in the merge queue if it was skipped on CI -- as discussed at #32973.
This should work with required checks:
per https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks
Testing
#36108 is a faux-dependabot PR that updates the workflow, targeting this branch. We expect OS compat to fail on this pr.
#36107 here is a docs only change targeting this branch. We expect OS compat to not run (but pass) on this PR.
OS compat is seen to run on this PR here: https://github.com/gravitational/teleport/actions/runs/7352008654/job/20016164332?pr=36105