Use actions/download-artifact@v3 instead of master #35953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward compatibility is not guaranteed on master, but is on any semver major version.
wadells
requested review from
klizhentas,
russjones,
r0mant,
zmb3,
fheinecke,
camscale and
tcsc
as code owners
wadells
changed the title
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
1 similar comment
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
camscale
approved these changes
Dec 20, 2023
wadells
changed the title
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
wadells
added
the
no-changelog
reedloden
approved these changes
Dec 21, 2023
jentfoo
approved these changes
Dec 22, 2023
nklaassen
approved these changes
Dec 26, 2023
public-teleport-github-review-bot
bot
removed the request for review
from jimbishopp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward compatibility is not guaranteed on master, but is on any semver major version. We got lucky this didn't break last week when #35845 came out.
I'll pick up the upgrade to v4 when #35845 merges.
I did check that we didn't have any other
@masterversions in teleport when I found this:I deemed all of these acceptable, since we're in control of the upstream, and can easily address/rollback breaking changes there.