[v14] Adjust diagnostic messages of connection test for Connect My Computer#35649
Merged
ravicious merged 2 commits intobranch/v14from Dec 12, 2023
Merged
[v14] Adjust diagnostic messages of connection test for Connect My Computer#35649ravicious merged 2 commits intobranch/v14from
ravicious merged 2 commits intobranch/v14from
Conversation
* Use JSDocs in services/agents/types.ts * TextIcon: Align icon to top rather than center When showing multiple TextIcons one after another, like when showing connection diagnostic traces, it makes it easier to see where one trace starts and another ends. Especially if one of the traces spans multiple lines. * Preserve line breaks from trace messages in UI * Add ResourceTile to TestConnectionRequest * Adjust diagnostic messages for Connect * Remove LegacyTestConnection * Offer better diag msg depending on SSH principal selection mode * Suggest systemctl/launchctl depending on platform * Rename ResourceTile to SSHNodeSetupMethod * Add tests for launchctl vs systemctl * Fix test after removal of "Linux" from "valid Linux login" * Add tests for SSHConnectionTester * Document valid values for SSHNodeSetupMethod * Remove test for principal with no OS permissions to run as In CI, it looks like we can absolutely spawn a new session as root, so the test is meaningless there. Instead, I'm going to add authhandlers tests and this test to the Connect My Computer test plan.
marcoandredinis
approved these changes
Dec 12, 2023
kimlisa
approved these changes
Dec 12, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #35308.
Backport was not clean because git complained about
LegacyConnectionTestthat this PR removes, idk why, it wasn't updated on v14 since it was originally added. It also had the same conflict as #35194 where somestorageServicechanges related to new v15 features weren't backported to v14.Changelog: Added a connection test when enrolling a new Connect My Computer resource in Web UI