[v14] Discover: Add UI for connection test for Connect My Computer#35194
Merged
ravicious merged 1 commit intobranch/v14from Nov 30, 2023
Merged
[v14] Discover: Add UI for connection test for Connect My Computer#35194ravicious merged 1 commit intobranch/v14from
ravicious merged 1 commit intobranch/v14from
Conversation
* Rename existing component to LegacyTestConnection * Set up new component with feature flag * Copy server TestConnection to Connect My Computer * ConnectionDiagnosticResult: Add prop for having step number and desc on same line This will be needed in connection test for Connect My Computer to make it consistent with the look of previous steps. * Adjust TestConnection to Connect My Computer, add story * Start test automatically if there's one login
gzdunek
approved these changes
Nov 30, 2023
zmb3
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #35131.
Auto backport was not clean because of external audit storage changes in storagesService that were not backported to v14.