[v13] tsh puttyconfig#33543
Merged
webvictim merged 12 commits intobranch/v13from Oct 20, 2023
Merged
Conversation
…to Windows registry
Fixes an extra full stop and tenant name which was included accidentally.
…chHosts (#32598) * puttyconfig: Switch to string-based Validity format and deprecate MatchHosts * Switch to more restrictive, reliable parsing * Add validity string errors to docs * Remove invalid test case * Add test case * Remove any spaces from user-provided input and use sanitized hostname * Apply fixes from code review * Tidy up errors, provide consistent detail about which field contains an error * Disable docs lint for dots in heading This is needed here, as there are 5 error messages which all start the same way but end differently. * Catch a few more error cases * Only delete old MatchHosts key after new Validity key has been written successfully * Apply suggestions from code review Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * Address Zac's comments from code review --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
webvictim
requested review from
lsgunn-teleport,
nklaassen,
ptgott,
rosstimothy,
timothyb89 and
zmb3
|
@webvictim - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
github-actions
Bot
added
size/xl
tsh
ptgott
approved these changes
Oct 17, 2023
nklaassen
approved these changes
Oct 18, 2023
jakule
approved these changes
Oct 19, 2023
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
zmb3
approved these changes
Oct 20, 2023
public-teleport-github-review-bot
Bot
removed request for
lsgunn-teleport,
rosstimothy and
timothyb89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following PRs to
branch/v13:tsh puttyconfig#29458Changelog:
Enhanced PuTTY/WinSCP Support
tshon Windows now supports thetsh puttyconfigcommand, which can easily configure saved sessions inside the well-known PuTTY and WinSCP clients to connect to Teleport SSH services.For more information, see docs.