tsh: Add support for host:port combinations to tsh puttyconfig#33518
Merged
tsh: Add support for host:port combinations to tsh puttyconfig#33518
Conversation
webvictim
added
documentation
tsh
github-actions
Bot
requested review from
jimbishopp,
lsgunn-teleport,
ptgott,
r0mant,
xinding33 and
zmb3
webvictim
requested review from
nklaassen and
timothyb89
and removed request for
jimbishopp,
r0mant and
xinding33
Contributor
|
🤖 Vercel preview here: https://docs-mwf162qkz-goteleport.vercel.app/docs/ver/preview |
Contributor
|
🤖 Vercel preview here: https://docs-716230nlb-goteleport.vercel.app/docs/ver/preview |
Contributor
|
🤖 Vercel preview here: https://docs-3hkgo0io0-goteleport.vercel.app/docs/ver/preview |
Contributor
|
🤖 Vercel preview here: https://docs-p5cwkkygg-goteleport.vercel.app/docs/ver/preview |
ptgott
approved these changes
Oct 17, 2023
nklaassen
approved these changes
Oct 18, 2023
tigrato
approved these changes
Oct 20, 2023
public-teleport-github-review-bot
Bot
removed request for
lsgunn-teleport,
timothyb89 and
zmb3
AntonAM
approved these changes
Oct 20, 2023
tigrato
approved these changes
Oct 20, 2023
Contributor
|
🤖 Vercel preview here: https://docs-jgcraay1l-goteleport.vercel.app/docs/ver/preview |
Contributor
|
🤖 Vercel preview here: https://docs-qige12rcu-goteleport.vercel.app/docs/ver/preview |
|
@webvictim See the table below for backport results.
|
webvictim
added a commit
that referenced
this pull request
Oct 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for using the
host:portformat to thetsh puttyconfigcommand, for example when adding sessions targetting registered OpenSSH nodes withtsh puttyconfig user@host:22It also updates the PuTTY docs to add an example of using
tsh puttyconfig --port 22 user@host(which was already supported) and adds some additional details to the troubleshooting section.v13 backport depends on #33543 being merged -
do-not-mergeuntil then.