Conversation
github-actions
Bot
requested review from
alexfornuto,
lsgunn-teleport,
ptgott,
r0mant,
xinding33 and
zmb3
Contributor
lsgunn-teleport
left a comment
lsgunn-teleport
left a comment
There was a problem hiding this comment.
Some suggestions with the biggest change around converting code comments into steps.
Contributor
Author
|
Thanks for the review @lsgunn-teleport! |
lsgunn-teleport
approved these changes
Jul 31, 2023
Comment on lines
+37
to
+42
|
|
||
| ```bash | ||
| C:\Users\gus>tsh login --proxy=teleport.example.com | ||
| ``` | ||
|
|
||
| This command retrieves your user certificates and saves them in a local file in the `%USERPROFILE%/.tsh` directory. |
Contributor
There was a problem hiding this comment.
This is a really minor thing for future reference. If you indent three spaces under a step, the text lines up nicely.
I'll make a quick pass through to fix this when I have a few minutes, but no reason to hold this PR up for it.
C:\Users\gus>tsh login --proxy=teleport.example.com
public-teleport-github-review-bot
Bot
removed request for
alexfornuto,
ptgott,
r0mant,
stevenGravy and
xinding33
zmb3
added
release-notes
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds documentation for
tsh puttyconfig.No backport required, as this functionality is only in
masterand won't be released until Teleport 14 comes out.