Revert private key policy error handling in WebUI#32918
Merged
Conversation
Joerger
force-pushed
the
joerger/enable-webui-with-hardware-key-support
branch
from
c8f46ef to
94e13b6
Compare
Joerger
force-pushed
the
joerger/enable-webui-with-hardware-key-support
branch
4 times, most recently
from
9035b9e to
5b895b8
Compare
ravicious
approved these changes
Oct 4, 2023
Member
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
Tested by compiling both OSS and e and logging in to both Web UIs.
kimlisa
approved these changes
Oct 4, 2023
Contributor
There was a problem hiding this comment.
don't think this was intended?
Contributor
Author
There was a problem hiding this comment.
Plan is to update e ref here to https://github.com/gravitational/teleport.e/pull/2344, merge https://github.com/gravitational/teleport.e/pull/2344, then update e ref to e/master.
Merging this without the e changes will cause e to break/fail tests, but I'll see if there is a way to go that route.
public-teleport-github-review-bot
Bot
removed the request for review
from gzdunek
Joerger
force-pushed
the
joerger/enable-webui-with-hardware-key-support
branch
from
5b895b8 to
ff8d77d
Compare
Joerger
force-pushed
the
joerger/enable-webui-with-hardware-key-support
branch
from
ff8d77d to
589e330
Compare
Joerger
force-pushed
the
joerger/enable-webui-with-hardware-key-support
branch
from
589e330 to
f07a400
Compare
This was referenced Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts gravitational/webapps#1298 so that the WebUI will work with Hardware Key support once #32781 is merged.
e PR https://github.com/gravitational/teleport.e/pull/2344