[v13] tsh and tctl ux backport#32005
Closed
GavinFrazar wants to merge 13 commits intobranch/v13from
Closed
Conversation
…format backports #29887 to branch/v13. * display discovered resource name in tctl output * display the discovered name from label in non-verbose text format for db, db_server, kube_cluster, kube_server resources. * support labels, predicate, search in tctl kube ls * avoid type conversion in tctl db ls * sort kube and db objects in tctl text tables * test kube/database collection text format output * check column indices are in range
backports #30149 to branch/v13. * update tsh kube ls tests * fix SiteName godoc typo
backports #30196 to branch/v13. * factor out discovered name func from tsh and tctl into tool/common
backports #30081 to branch/v13. * prefix matching for tctl get discovery resources: * kube_cluster * kube_server * db * db_server * skip 500ms wait for 0 databases in tests
backports #30167 to branch/v13. * Fix Kubernetes selected cluster Kubeconfig context name can be customized using `--set-context-name` flag. When using it, the selected Kubernetes cluster fails to correctly identify the cluster name.
backports #30252 to branch/v13. * fetch kube clusters once for login
backports #30478 to branch/v13. * select by labels, query predicate, name, and/or prefix of name. * fix --cluster flag not being propagated
backports #30531 to branch/v13.
backports #31744 to branch/v13.
backports #31689 to branch/v13. * disallow prefix matching * select by exact name match first, * otherwise look for unambiguous discovered name label match. * look for an active db to resolve discovered name match ambiguity. * add more predicate builder helpers * check for db name in not found error for stale cert hint * no error status on tsh db logout with no logged in dbs * remove dead code * refactor helper funcs to simplify code and make it easier to test * test complex database selection * test findActiveDatabase * test choosing one db by discovered name * add more resource selectors tests * test formatDatabaseLoginCommand * add debug logging for db selection
Contributor
Author
|
@smallinsky @greedy52 @tigrato if this is too much for reviewers, I can split this into separate stacked backport PRs by cherry-picking from this branch, to spread the work around. 4k line diff is pretty ridiculous 🤣 edit: I think i'm just going to do after that this weekend, and just start merging the stacked PRs into branch/v13 once they're all approved. That way we can get multiple people to review. |
Contributor
Author
|
closing in favor of individual stacked backports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports several
tshandtctlux change PRs to branch/v13.I batched them together because it would be a nightmare to resolve diff conflicts otherwise.
I was holding off on backporting these changes until after the v14 test plan was completed.
Leaving it in draft for now for CI run
PRs backported (from most recent to least recent merge into master):
#31689
#31744
#30531
#30478
#30252
#30167
#30081
#30196
#30149
#29887
#30024
#29562
The merge commits from these PRs were cherry-picked in the same order as they were committed to master.
the diff conflicts weren't too bad, but there were a few for several commits.