Skip to content

Deflake TestListKube#30024

Merged
tigrato merged 3 commits intomasterfrom
tigrato/fix-flaky-kube-test-2
Aug 4, 2023
Merged

Deflake TestListKube#30024
tigrato merged 3 commits intomasterfrom
tigrato/fix-flaky-kube-test-2

Conversation

@tigrato
Copy link
Copy Markdown
Contributor

@tigrato tigrato commented Aug 4, 2023

PR #29993 tried to deflake this test but only fixed it partially during login.
This prevents the kubeconfig in $HOME/.kube/config to be used everywhere

PR #29993 tried to deflake this test but only fixed it partially during
login.
This prevents the kubeconfig in `$HOME/.kube/config` to be used
everywhere

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
@github-actions github-actions Bot added size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Aug 4, 2023
@GavinFrazar
Copy link
Copy Markdown
Contributor

I was just about to open this :)

If I run the entire tsh test suite, something still generates a kubeconfig in ~/.kube/config though

@tcsc
Copy link
Copy Markdown
Contributor

tcsc commented Aug 4, 2023

something still generates a kubeconfig in ~/.kube/config though

There appears to be a heap of places in tsh that do not honour the parameters passed in through the CLIConf and just reach for whatever is in $KUBECONFIG (or $HOME/.kube/config of that is empty). I've highlighted a few, but I'm 100% sure others exist.

@tigrato tigrato added this pull request to the merge queue Aug 4, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 4, 2023
@tigrato tigrato added this pull request to the merge queue Aug 4, 2023
Merged via the queue into master with commit d13d1e3 Aug 4, 2023
@tigrato tigrato deleted the tigrato/fix-flaky-kube-test-2 branch August 4, 2023 09:38
@public-teleport-github-review-bot
Copy link
Copy Markdown

@tigrato See the table below for backport results.

Branch Result
branch/v12 Failed
branch/v13 Failed

@GavinFrazar
Copy link
Copy Markdown
Contributor

@tigrato also this one for backport?

GavinFrazar pushed a commit that referenced this pull request Sep 16, 2023
backports #30024 to branch/v13.

* Deflake `TestListKube`
* Plumbing through custom kube config path

PR #29993 tried to deflake this test but only fixed it partially during
login.
This prevents the kubeconfig in `$HOME/.kube/config` to be used
everywhere
GavinFrazar pushed a commit that referenced this pull request Sep 18, 2023
backports #30024 to branch/v13.

* Deflake `TestListKube`
* Plumbing through custom kube config path

PR #29993 tried to deflake this test but only fixed it partially during
login.
This prevents the kubeconfig in `$HOME/.kube/config` to be used
everywhere
github-merge-queue Bot pushed a commit that referenced this pull request Sep 18, 2023
backports #30024 to branch/v13.

* Deflake `TestListKube`
* Plumbing through custom kube config path

PR #29993 tried to deflake this test but only fixed it partially during
login.
This prevents the kubeconfig in `$HOME/.kube/config` to be used
everywhere

Co-authored-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue Bot pushed a commit that referenced this pull request Sep 18, 2023
#32083)

* [v13] Deflake `TestListKube`

backports #30024 to branch/v13.

* Deflake `TestListKube`
* Plumbing through custom kube config path

PR #29993 tried to deflake this test but only fixed it partially during
login.
This prevents the kubeconfig in `$HOME/.kube/config` to be used
everywhere

* [v13] handle discovery renaming when listing resource in `tctl` text format

backports #29887 to branch/v13.

* display discovered resource name in tctl output
* display the discovered name from label in non-verbose text format for
  db, db_server, kube_cluster, kube_server resources.
* support labels, predicate, search in tctl kube ls
* avoid type conversion in tctl db ls
* sort kube and db objects in tctl text tables
* test kube/database collection text format output
* check column indices are in range

---------

Co-authored-by: Tiago Silva <tiago.silva@goteleport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants