Fix tool.tsh.common.TestKube/list_kube flaky test#29993
Merged
Conversation
github-actions
Bot
added
size/sm
tsh
codingllama
approved these changes
Aug 3, 2023
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
Contributor
|
Should we backport this too? |
greedy52
approved these changes
Aug 3, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from probakowski
codingllama
approved these changes
Aug 3, 2023
Tests under `tool.tsh.common.TestKube/list_kube` were picking the leftovers of another test which defined the `$HONE/.kube/config` file. This caused the test to be flaky because depending on the tests runnning order, some kube clusters appeared as selected when running `tsh kube ls`. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
force-pushed
the
tigrato/fix-flaky-kube-test
branch
from
c19db9c to
f596040
Compare
This was referenced Aug 3, 2023
tigrato
added a commit
that referenced
this pull request
Aug 4, 2023
PR #29993 tried to deflake this test but only fixed it partially during login. This prevents the kubeconfig in `$HOME/.kube/config` to be used everywhere Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
Merged
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
* Deflake `TestListKube` PR #29993 tried to deflake this test but only fixed it partially during login. This prevents the kubeconfig in `$HOME/.kube/config` to be used everywhere Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * Plumbing through custom kube config path * Update kube.go --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: Trent Clarke <trent@goteleport.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 18, 2023
backports #30024 to branch/v13. * Deflake `TestListKube` * Plumbing through custom kube config path PR #29993 tried to deflake this test but only fixed it partially during login. This prevents the kubeconfig in `$HOME/.kube/config` to be used everywhere Co-authored-by: Tiago Silva <tiago.silva@goteleport.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 18, 2023
#32083) * [v13] Deflake `TestListKube` backports #30024 to branch/v13. * Deflake `TestListKube` * Plumbing through custom kube config path PR #29993 tried to deflake this test but only fixed it partially during login. This prevents the kubeconfig in `$HOME/.kube/config` to be used everywhere * [v13] handle discovery renaming when listing resource in `tctl` text format backports #29887 to branch/v13. * display discovered resource name in tctl output * display the discovered name from label in non-verbose text format for db, db_server, kube_cluster, kube_server resources. * support labels, predicate, search in tctl kube ls * avoid type conversion in tctl db ls * sort kube and db objects in tctl text tables * test kube/database collection text format output * check column indices are in range --------- Co-authored-by: Tiago Silva <tiago.silva@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests under
tool.tsh.common.TestKube/list_kubewere picking the leftovers of another test which defined the$HONE/.kube/configfile. This caused the test to be flaky because depending on the tests runnning order, some kube clusters appeared as selected when runningtsh kube ls.