[v13] Remove lib/auth/webauthn dependency from webauthncli#30498
Merged
Conversation
* Represent the entirety of protocol within lib/auth/webauthn * Bump github.com/go-webauthn/webauthn to v0.6.2 * Fixes for v0.6.x: Challenge, RPOrigins * Bump github.com/go-webauthn/webauthn to v0.7.2 * Document new v0.7.2 fields * Bump github.com/go-webauthn/webauthn to v0.8.2 * Fixes for v0.8.x: UserEntity.ID * Bump github.com/go-webauthn/webauthn to v0.8.6 * Let bots update go-webauthn * Drop support for RP and User icon * Update generated protos * Add a brief godoc to cloned types
* Alias `api/types/webauthn` imports to `wanpb` * Use `webauthnpb` as the default package name * Move messages.go to webauthntypes/ * Move extensions.go to webauthntypes/ * Move proto.go to webauthntypes/ * nit: Use consistent license style * Use the `wantypes` alias for webauthntypes * Use the `wanwin` alias for webauthnwin * nit: Move winwebauthn.go to webauthnwin.go * Document package webauthntypes * Alias types required by e/ * Appease linter * Add all main types/method to compat.go * Reinstate spaces on proxy_test.go * Alias newly-added usages
github-actions
Bot
requested review from
jentfoo,
strideynet and
tobiaszheller
github-actions
Bot
added
backport
desktop-access
size/sm
tsh
Contributor
Author
|
I started with #30377 but quickly realized it builds on the go-webauthn PR, so I pulled that in as well. The result is still trivial, but visual inspection is recommended: there were various small conflicts here and there. |
codingllama
changed the title
lib/auth/webauthn dependency from webauthncli
Joerger
approved these changes
Aug 15, 2023
jentfoo
approved these changes
Aug 15, 2023
rosstimothy
approved these changes
Aug 15, 2023
public-teleport-github-review-bot
Bot
removed request for
strideynet,
tobiaszheller and
zmb3
Contributor
Author
|
FYI, I'm leaving v11 out of this batch of backports. It still runs duo-labs/webauthn and it won't be live for long either, so I don't think the effort is justified now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #29750 (minus the actual lib update), #30377 and #30314 to branch/v13.
Backport a series of recent lib/auth/webauthn refactors, culminating with #30377, for parity with the master branch.
No behavioral changes expected.