Represent protocol within wanlib and update go-webauthn#29750
Merged
codingllama merged 12 commits intomasterfrom Aug 2, 2023
Merged
Represent protocol within wanlib and update go-webauthn#29750codingllama merged 12 commits intomasterfrom
protocol within wanlib and update go-webauthn#29750codingllama merged 12 commits intomasterfrom
Conversation
codingllama
force-pushed
the
codingllama/wan-interface
branch
from
9a232b3 to
3a769f4
Compare
tobiaszheller
approved these changes
Jul 31, 2023
Contributor
tobiaszheller
left a comment
tobiaszheller
left a comment
There was a problem hiding this comment.
lgtm, can you also check it with new and old version of server?
jentfoo
approved these changes
Jul 31, 2023
rosstimothy
reviewed
Jul 31, 2023
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
Tested using pre- and post-update tsh binaries.
What was the version matrix that was tested? Did we test new/old tsh against new/old Auth?
Contributor
Author
The matrix goes somewhat like this:
Edit: tested "tsh new" + "server old". |
Contributor
Author
|
Oh, just to add a bit more detail, I tested both with carried over credentials (MFA, Passwordless and Touch ID) and then tested deleting/adding new credentials with the "new"+"new" combination, just to be sure. |
Contributor
Author
|
PTAL, test matrix complete. |
Contributor
Author
|
Friendly ping @rosstimothy ? |
codingllama
force-pushed
the
codingllama/wan-interface
branch
from
3a769f4 to
8b2dae3
Compare
Contributor
Author
|
PTAL @rosstimothy ? |
rosstimothy
approved these changes
Aug 2, 2023
zmb3
approved these changes
Aug 2, 2023
strideynet
approved these changes
Aug 2, 2023
codingllama
added a commit
that referenced
this pull request
Aug 15, 2023
* Represent the entirety of protocol within lib/auth/webauthn * Bump github.com/go-webauthn/webauthn to v0.6.2 * Fixes for v0.6.x: Challenge, RPOrigins * Bump github.com/go-webauthn/webauthn to v0.7.2 * Document new v0.7.2 fields * Bump github.com/go-webauthn/webauthn to v0.8.2 * Fixes for v0.8.x: UserEntity.ID * Bump github.com/go-webauthn/webauthn to v0.8.6 * Let bots update go-webauthn * Drop support for RP and User icon * Update generated protos * Add a brief godoc to cloned types
codingllama
added a commit
that referenced
this pull request
Aug 15, 2023
* Represent the entirety of protocol within lib/auth/webauthn * Bump github.com/go-webauthn/webauthn to v0.6.2 * Fixes for v0.6.x: Challenge, RPOrigins * Bump github.com/go-webauthn/webauthn to v0.7.2 * Document new v0.7.2 fields * Bump github.com/go-webauthn/webauthn to v0.8.2 * Fixes for v0.8.x: UserEntity.ID * Bump github.com/go-webauthn/webauthn to v0.8.6 * Let bots update go-webauthn * Drop support for RP and User icon * Update generated protos * Add a brief godoc to cloned types
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 15, 2023
* Represent `protocol` within `wanlib` and update go-webauthn (#29750) * Represent the entirety of protocol within lib/auth/webauthn * Bump github.com/go-webauthn/webauthn to v0.6.2 * Fixes for v0.6.x: Challenge, RPOrigins * Bump github.com/go-webauthn/webauthn to v0.7.2 * Document new v0.7.2 fields * Bump github.com/go-webauthn/webauthn to v0.8.2 * Fixes for v0.8.x: UserEntity.ID * Bump github.com/go-webauthn/webauthn to v0.8.6 * Let bots update go-webauthn * Drop support for RP and User icon * Update generated protos * Add a brief godoc to cloned types * Undo go-webauthn compatibility changes * Remove `lib/auth/webauthn` dependency from `webauthncli` (#30377) * Alias `api/types/webauthn` imports to `wanpb` * Use `webauthnpb` as the default package name * Move messages.go to webauthntypes/ * Move extensions.go to webauthntypes/ * Move proto.go to webauthntypes/ * nit: Use consistent license style * Use the `wantypes` alias for webauthntypes * Use the `wanwin` alias for webauthnwin * nit: Move winwebauthn.go to webauthnwin.go * Document package webauthntypes * Alias types required by e/ * Appease linter * Add all main types/method to compat.go * Reinstate spaces on proxy_test.go * Alias newly-added usages * chore: Drop the lib/auth/webauthn/httpserver test package (#30314)
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 15, 2023
* Represent `protocol` within `wanlib` and update go-webauthn (#29750) * Represent the entirety of protocol within lib/auth/webauthn * Bump github.com/go-webauthn/webauthn to v0.6.2 * Fixes for v0.6.x: Challenge, RPOrigins * Bump github.com/go-webauthn/webauthn to v0.7.2 * Document new v0.7.2 fields * Bump github.com/go-webauthn/webauthn to v0.8.2 * Fixes for v0.8.x: UserEntity.ID * Bump github.com/go-webauthn/webauthn to v0.8.6 * Let bots update go-webauthn * Drop support for RP and User icon * Update generated protos * Add a brief godoc to cloned types * Undo go-webauthn compatibility changes * Remove `lib/auth/webauthn` dependency from `webauthncli` (#30377) * Alias `api/types/webauthn` imports to `wanpb` * Use `webauthnpb` as the default package name * Move messages.go to webauthntypes/ * Move extensions.go to webauthntypes/ * Move proto.go to webauthntypes/ * nit: Use consistent license style * Use the `wantypes` alias for webauthntypes * Use the `wanwin` alias for webauthnwin * nit: Move winwebauthn.go to webauthnwin.go * Document package webauthntypes * Alias types required by e/ * Appease linter * Add all main types/method to compat.go * Reinstate spaces on proxy_test.go * Alias newly-added usages * chore: Drop the lib/auth/webauthn/httpserver test package (#30314) * Change httpfallback.go imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Represent the entirety of go-webauthn's protocol within
lib/auth/webauthn, instead of only "leaf" types, so we are isolated from library JSON marshal changes (which there are plenty).This allows us to update go-webauthn without potential compatibility breakages between Teleport versions, pushing us all the way the latest dependency. (We don't care whether bytes are Standard- or RawURL-encoded, transport is settled for us.)
Tested using pre- and post-update
tshbinaries.