Remove lib/auth/webauthn dependency from webauthncli#30377
Merged
codingllama merged 15 commits intomasterfrom Aug 14, 2023
Merged
Remove lib/auth/webauthn dependency from webauthncli#30377codingllama merged 15 commits intomasterfrom
lib/auth/webauthn dependency from webauthncli#30377codingllama merged 15 commits intomasterfrom
Conversation
Contributor
Author
|
Easier to understand commit-by-commit. It's a bit uninteresting to review, but should be fairly mechanical - it's mostly moves and renames, no real changes. I'll take a look at the linter and failed tests (I think I trimmed some spaces that were actually important?) |
Contributor
Author
|
Package deps: # lib/auth/touchid
$ go list -f '{{range $i, $pkg := .Deps}}{{printf "%s\n" $pkg}}{{end}}' ./lib/auth/touchid | grep gravitational
github.com/gravitational/teleport/api/types/webauthn
github.com/gravitational/teleport/lib/auth/webauthntypes
github.com/gravitational/teleport/lib/darwin
github.com/gravitational/trace
github.com/gravitational/trace/internal
# lib/auth/webauthnwin
$ go list -f '{{range $i, $pkg := .Deps}}{{printf "%s\n" $pkg}}{{end}}' ./lib/auth/webauthnwin | grep gravitational
github.com/gravitational/teleport/api
github.com/gravitational/teleport/api/client/proto
github.com/gravitational/teleport/api/constants
github.com/gravitational/teleport/api/defaults
github.com/gravitational/teleport/api/gen/proto/go/attestation/v1
github.com/gravitational/teleport/api/gen/proto/go/teleport/accesslist/v1
github.com/gravitational/teleport/api/gen/proto/go/teleport/auditlog/v1
github.com/gravitational/teleport/api/gen/proto/go/teleport/devicetrust/v1
github.com/gravitational/teleport/api/gen/proto/go/teleport/header/v1
github.com/gravitational/teleport/api/gen/proto/go/teleport/trait/v1
github.com/gravitational/teleport/api/gen/proto/go/teleport/userloginstate/v1
github.com/gravitational/teleport/api/gen/proto/go/usageevents/v1
github.com/gravitational/teleport/api/types
github.com/gravitational/teleport/api/types/common
github.com/gravitational/teleport/api/types/events
github.com/gravitational/teleport/api/types/webauthn
github.com/gravitational/teleport/api/types/wrappers
github.com/gravitational/teleport/api/utils
github.com/gravitational/teleport/api/utils/atlas
github.com/gravitational/teleport/api/utils/aws
github.com/gravitational/teleport/api/utils/azure
github.com/gravitational/teleport/api/utils/keys
github.com/gravitational/teleport/api/utils/sshutils/ppk
github.com/gravitational/teleport/api/utils/tlsutils
github.com/gravitational/teleport/lib/auth/webauthntypes
github.com/gravitational/trace
github.com/gravitational/trace/internal
If you |
rosstimothy
approved these changes
Aug 11, 2023
Joerger
approved these changes
Aug 12, 2023
fd92980 to
571861e
Compare
Collaborator
|
/excludeflake * |
You're not authorized to push to this branch. Visit "About protected branches" for more information.
|
@codingllama See the table below for backport results.
|
codingllama
added a commit
that referenced
this pull request
Aug 15, 2023
* Alias `api/types/webauthn` imports to `wanpb` * Use `webauthnpb` as the default package name * Move messages.go to webauthntypes/ * Move extensions.go to webauthntypes/ * Move proto.go to webauthntypes/ * nit: Use consistent license style * Use the `wantypes` alias for webauthntypes * Use the `wanwin` alias for webauthnwin * nit: Move winwebauthn.go to webauthnwin.go * Document package webauthntypes * Alias types required by e/ * Appease linter * Add all main types/method to compat.go * Reinstate spaces on proxy_test.go * Alias newly-added usages
codingllama
added a commit
that referenced
this pull request
Aug 15, 2023
* Alias `api/types/webauthn` imports to `wanpb` * Use `webauthnpb` as the default package name * Move messages.go to webauthntypes/ * Move extensions.go to webauthntypes/ * Move proto.go to webauthntypes/ * nit: Use consistent license style * Use the `wantypes` alias for webauthntypes * Use the `wanwin` alias for webauthnwin * nit: Move winwebauthn.go to webauthnwin.go * Document package webauthntypes * Alias types required by e/ * Appease linter * Add all main types/method to compat.go * Reinstate spaces on proxy_test.go * Alias newly-added usages
This was referenced Aug 15, 2023
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 15, 2023
* Represent `protocol` within `wanlib` and update go-webauthn (#29750) * Represent the entirety of protocol within lib/auth/webauthn * Bump github.com/go-webauthn/webauthn to v0.6.2 * Fixes for v0.6.x: Challenge, RPOrigins * Bump github.com/go-webauthn/webauthn to v0.7.2 * Document new v0.7.2 fields * Bump github.com/go-webauthn/webauthn to v0.8.2 * Fixes for v0.8.x: UserEntity.ID * Bump github.com/go-webauthn/webauthn to v0.8.6 * Let bots update go-webauthn * Drop support for RP and User icon * Update generated protos * Add a brief godoc to cloned types * Undo go-webauthn compatibility changes * Remove `lib/auth/webauthn` dependency from `webauthncli` (#30377) * Alias `api/types/webauthn` imports to `wanpb` * Use `webauthnpb` as the default package name * Move messages.go to webauthntypes/ * Move extensions.go to webauthntypes/ * Move proto.go to webauthntypes/ * nit: Use consistent license style * Use the `wantypes` alias for webauthntypes * Use the `wanwin` alias for webauthnwin * nit: Move winwebauthn.go to webauthnwin.go * Document package webauthntypes * Alias types required by e/ * Appease linter * Add all main types/method to compat.go * Reinstate spaces on proxy_test.go * Alias newly-added usages * chore: Drop the lib/auth/webauthn/httpserver test package (#30314)
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 15, 2023
* Represent `protocol` within `wanlib` and update go-webauthn (#29750) * Represent the entirety of protocol within lib/auth/webauthn * Bump github.com/go-webauthn/webauthn to v0.6.2 * Fixes for v0.6.x: Challenge, RPOrigins * Bump github.com/go-webauthn/webauthn to v0.7.2 * Document new v0.7.2 fields * Bump github.com/go-webauthn/webauthn to v0.8.2 * Fixes for v0.8.x: UserEntity.ID * Bump github.com/go-webauthn/webauthn to v0.8.6 * Let bots update go-webauthn * Drop support for RP and User icon * Update generated protos * Add a brief godoc to cloned types * Undo go-webauthn compatibility changes * Remove `lib/auth/webauthn` dependency from `webauthncli` (#30377) * Alias `api/types/webauthn` imports to `wanpb` * Use `webauthnpb` as the default package name * Move messages.go to webauthntypes/ * Move extensions.go to webauthntypes/ * Move proto.go to webauthntypes/ * nit: Use consistent license style * Use the `wantypes` alias for webauthntypes * Use the `wanwin` alias for webauthnwin * nit: Move winwebauthn.go to webauthnwin.go * Document package webauthntypes * Alias types required by e/ * Appease linter * Add all main types/method to compat.go * Reinstate spaces on proxy_test.go * Alias newly-added usages * chore: Drop the lib/auth/webauthn/httpserver test package (#30314) * Change httpfallback.go imports
This was referenced Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanly separate server-side and client-side WebAuthn packages by moving shared type definitions to a new package, called
webauthntypes.The following changes are made:
wantypeswantypes, are now aliasedwanpbwanwin, for brevity and consistencyNo functional changes. Refactors are either IDE-driven or the result of simple seds.