[v12] Fix tool.tsh.common.TestKube/list_kube flaky test#29999
Merged
tigrato merged 1 commit intobranch/v12from Aug 3, 2023
Merged
[v12] Fix tool.tsh.common.TestKube/list_kube flaky test#29999tigrato merged 1 commit intobranch/v12from
tool.tsh.common.TestKube/list_kube flaky test#29999tigrato merged 1 commit intobranch/v12from
Conversation
Tests under `tool.tsh.common.TestKube/list_kube` were picking the leftovers of another test which defined the `$HONE/.kube/config` file. This caused the test to be flaky because depending on the tests runnning order, some kube clusters appeared as selected when running `tsh kube ls`. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-actions
Bot
added
backport
size/sm
tsh
codingllama
approved these changes
Aug 3, 2023
greedy52
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #29993 to branch/v12