[v13] Port and refactor Mattermost from teleport-plugins (#28989)#29549
Merged
kimlisa merged 3 commits intobranch/v13from Jul 26, 2023
Merged
[v13] Port and refactor Mattermost from teleport-plugins (#28989)#29549kimlisa merged 3 commits intobranch/v13from
kimlisa merged 3 commits intobranch/v13from
Conversation
|
@kimlisa - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
github-actions
Bot
requested review from
justinas,
r0mant,
rosstimothy and
tigrato
r0mant
approved these changes
Jul 25, 2023
tigrato
approved these changes
Jul 25, 2023
public-teleport-github-review-bot
Bot
removed request for
justinas and
rosstimothy
* Copy files from teleport/plugins/access/mattermost * Add github.com/mailgun/holster/v3 * Define mattermost types * Move StatusFromStatusCode to commons dir * Make changes/ refactor based on other plugins - emit status
kimlisa
force-pushed
the
lisa/v13/mattermost
branch
8 times, most recently
from
aa7c1b3 to
6cfb0f9
Compare
Test similarly to slack since they both use commons/app.go
kimlisa
force-pushed
the
lisa/v13/mattermost
branch
from
6cfb0f9 to
9f27511
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #28989 to branch/v13
manual backport b/c of conflict in
pb.go(make grpc),go.sum(go mod tidy) and types file (weird git diff)