Conversation
- Remove unused, old data types - Add status test (sim to slack) - Fixed race conditions, based on slack_test.go (Mattermost got refactored to use common/apps.go like slack)
justinas
approved these changes
Jul 26, 2023
r0mant
approved these changes
Jul 26, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from tigrato
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some mattermost tests were being skipped in
masterCI, but was running inbranch/v13and failed, which pointed out problems with the mattermost test after the refactor.I tried out the fix in
branch/v13in this PR: #29549 (same changes), since it is set up to run CI with enterprise license (i haven't figured out how to run it locally yet)This is really a forward port