Port and refactor Mattermost from teleport-plugins#28989
Merged
Conversation
|
@kimlisa - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
kimlisa
requested review from
justinas,
mdwn and
tcsc
and removed request for
strideynet and
tigrato
justinas
approved these changes
Jul 14, 2023
tigrato
approved these changes
Jul 14, 2023
kimlisa
force-pushed
the
lisa/plugin-mattermost
branch
from
296d801 to
077b768
Compare
rosstimothy
reviewed
Jul 24, 2023
Contributor
There was a problem hiding this comment.
Please include this in the block above with all the direct dependencies
kimlisa
force-pushed
the
lisa/plugin-mattermost
branch
2 times, most recently
from
a79f25b to
1742167
Compare
2 tasks
kimlisa
force-pushed
the
lisa/plugin-mattermost
branch
from
1742167 to
f2f8efa
Compare
r0mant
approved these changes
Jul 24, 2023
- Re-use commons - Delete dups (most of app.go and version.go) - Moved looking up channel into bot.go - Emit status update after a response - Added missing? recipients section to example toml
- run go mod tidy - remove unused example config - fix ordering of imports
kimlisa
force-pushed
the
lisa/plugin-mattermost
branch
from
ffe8428 to
8573445
Compare
kimlisa
added a commit
that referenced
this pull request
Jul 26, 2023
* Copy files from teleport/plugins/access/mattermost * Add github.com/mailgun/holster/v3 * Define mattermost types * Move StatusFromStatusCode to commons dir * Make changes/ refactor based on other plugins - emit status
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
…9549) * Port and refactor Mattermost from teleport-plugins (#28989) * Copy files from teleport/plugins/access/mattermost * Add github.com/mailgun/holster/v3 * Define mattermost types * Move StatusFromStatusCode to commons dir * Make changes/ refactor based on other plugins - emit status * Fix test, remove old types used in tests Test similarly to slack since they both use commons/app.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recommend reviewing by commit (it will make it easier to see what changes i made aside copying over files)
Next
teleport-pluginsrepo with teleport dependencies (draft here)note: won't be back until 24th to address reviews