Skip to content

Fix Device Trust Logins#28729

Merged
rosstimothy merged 1 commit intomasterfrom
tross/fix_test_node_access
Jul 5, 2023
Merged

Fix Device Trust Logins#28729
rosstimothy merged 1 commit intomasterfrom
tross/fix_test_node_access

Conversation

@rosstimothy
Copy link
Copy Markdown
Contributor

@rosstimothy rosstimothy commented Jul 5, 2023 •
edited
Loading

#28499 missed adding the augmented device certificates retrieved from DeviceLogin to the local agent which causes TestNodeAccess to fail because device logins are using incorrect certs. This was not caught in #28499 because TestNodeAccess is in e and tests from e are not run on oss PRs.

@rosstimothy
Fix TestNodeAccess
98a3ba1 
#28499 missed adding the augmented device certificates retrieved from
DeviceLogin to the local agent which causes TestNodeAccess to fail.
This was not caught in #28499 because TestNodeAccess is in `e` and
tests from `e` are not run on `oss` PRs.
@github-actions github-actions Bot requested review from Joerger and zmb3 July 5, 2023 21:15
@codingllama
Copy link
Copy Markdown
Contributor

codingllama commented Jul 5, 2023

Is this a fix just for TestNodeAccess or are device trust certs broken for certain flows?

@rosstimothy rosstimothy enabled auto-merge July 5, 2023 21:25
@rosstimothy
Copy link
Copy Markdown
Contributor Author

rosstimothy commented Jul 5, 2023

Is this a fix just for TestNodeAccess or are device trust certs broken for certain flows?

The latter. I'll update the PR to reflect that.

@rosstimothy rosstimothy changed the title Fix TestNodeAccess Fix Device Trust Logins Jul 5, 2023
@rosstimothy rosstimothy added this pull request to the merge queue Jul 5, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 5, 2023
@rosstimothy rosstimothy added this pull request to the merge queue Jul 5, 2023
Merged via the queue into master with commit 336b891 Jul 5, 2023
@rosstimothy rosstimothy deleted the tross/fix_test_node_access branch July 5, 2023 22:03
ravicious pushed a commit that referenced this pull request Jul 11, 2023
@rosstimothy @ravicious
Fix TestNodeAccess (#28729)
601ec5c 
#28499 missed adding the augmented device certificates retrieved from
DeviceLogin to the local agent which causes TestNodeAccess to fail.
This was not caught in #28499 because TestNodeAccess is in `e` and
tests from `e` are not run on `oss` PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codingllama codingllama codingllama approved these changes

@GavinFrazar GavinFrazar GavinFrazar approved these changes

Assignees

No one assigned

Labels

size/sm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rosstimothy @codingllama @GavinFrazar