Extend AccessCapabilities#26968
Merged
rosstimothy merged 1 commit intomasterfrom May 26, 2023
Merged
Conversation
rosstimothy
force-pushed
the
tross/tsh_access_capabilties
branch
2 times, most recently
from
4a67733 to
70b20bd
Compare
Closed
`tsh login` was fetching each role for a user during login to perform calculations required to determine if auto access requests were required. To reduce some of the login latency this logic was moved to `proto.AuthService/GetAccessCapabilities` so that only a single RPC to Auth is required instead of one per role.
rosstimothy
force-pushed
the
tross/tsh_access_capabilties
branch
from
70b20bd to
ccba59c
Compare
github-actions
Bot
added
size/md
tsh
fspmarshall
approved these changes
May 26, 2023
mdwn
approved these changes
May 26, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from timothyb89
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tsh loginwas fetching each role for a user during login to perform calculations required to determine if auto access requests were required. To reduce some of the login latency this logic was moved toproto.AuthService/GetAccessCapabilitiesso that only a single RPC to Auth is required instead of one per role.Partly addresses #21841