[v12] Define a new DeviceEvent proto with the usual embeds#25555
Merged
codingllama merged 1 commit intobranch/v12from May 4, 2023
Merged
[v12] Define a new DeviceEvent proto with the usual embeds#25555codingllama merged 1 commit intobranch/v12from
codingllama merged 1 commit intobranch/v12from
Conversation
* Define a new, standardized device event * Update generated protos * Add OneOf support, swap legacy for new event * Do not mix old and new events
github-actions
Bot
added
audit-log
codingllama
commented
May 3, 2023
| events.DeviceEvent2 DeviceEvent2 = 121; | ||
| } | ||
|
|
||
| reserved 120; // OpenSearchRequest not backported. |
Contributor
Author
There was a problem hiding this comment.
Added this line for the backport.
Contributor
Author
|
Conflicts fixed on events.proto (see comments in file) and generated files (fixed using |
nklaassen
approved these changes
May 3, 2023
strideynet
approved these changes
May 3, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define a new base event for device trust, with the usual embeds of
StatusandUserMetadata.We can't swap the event in single PR as the code that issues it lives in e/, so it has to be done in multiple steps.
#25288
Backport #25355 to branch/v12