Skip to content

Use new device event layout in Web UI#25355

Merged
codingllama merged 3 commits intomasterfrom
codingllama/dt-deviceevent2-web
May 2, 2023
Merged

Use new device event layout in Web UI#25355
codingllama merged 3 commits intomasterfrom
codingllama/dt-deviceevent2-web

Conversation

@codingllama
Copy link
Copy Markdown
Contributor

Use the new device event layout, introduced by #25353, in the Web UI.

#25288

@codingllama
Copy link
Copy Markdown
Contributor Author

Ideally this lands after #25353 and https://github.com/gravitational/teleport.e/pull/1250, although there's little harm if it lands first. I'll be careful on merges and backports.

@codingllama codingllama force-pushed the codingllama/dt-deviceevent2-web branch from 194b6fa to 3b63c8f Compare April 28, 2023 22:11
@codingllama
Copy link
Copy Markdown
Contributor Author

I've reintroduced tests cases for old events and added a degree of backwards-compatibility to the code, so the Web UI behaves reasonably while "mixed" event formats exist.

I didn't try to handle both formats of the "user" field as it won't break the UI or print the wrong success/failure message, but old events will print the user as "[object Object]" in the transition.

I also retract myself, this should definitely land before we write new events, otherwise the UI breaks due to the lack of the "status" field.

@codingllama codingllama added this pull request to the merge queue May 2, 2023
Merged via the queue into master with commit 4d2b434 May 2, 2023
@codingllama codingllama deleted the codingllama/dt-deviceevent2-web branch May 2, 2023 19:00
@public-teleport-github-review-bot
Copy link
Copy Markdown

@codingllama See the table below for backport results.

Branch Result
branch/v12 Failed
branch/v13 Create PR

codingllama added a commit that referenced this pull request May 3, 2023
* Use new device event layout in Web UI

* Maintain compatibility with legacy/v12 events

* Update snapshots
codingllama added a commit that referenced this pull request May 4, 2023
* Use new device event layout in Web UI

* Maintain compatibility with legacy/v12 events

* Update snapshots
codingllama added a commit that referenced this pull request May 4, 2023
* Use new device event layout in Web UI

* Maintain compatibility with legacy/v12 events

* Update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants