Define a new DeviceEvent proto with the usual embeds#25353
Merged
codingllama merged 4 commits intomasterfrom May 2, 2023
Merged
Define a new DeviceEvent proto with the usual embeds#25353codingllama merged 4 commits intomasterfrom
codingllama merged 4 commits intomasterfrom
Conversation
github-actions
Bot
added
audit-log
zmb3
approved these changes
Apr 28, 2023
Contributor
Author
|
Changed oneof to not mix "old" and new "events", based on the event code. It's a bad idea to mix them, some fields like "user" changed type in a incompatible way. |
Contributor
Author
|
Friendly ping @nklaassen @rudream ? |
codingllama
force-pushed
the
codingllama/dt-deviceevent2
branch
from
68f206c to
cee80b6
Compare
nklaassen
approved these changes
May 2, 2023
|
@codingllama See the table below for backport results.
|
This was referenced May 3, 2023
codingllama
added a commit
that referenced
this pull request
May 3, 2023
* Define a new, standardized device event * Update generated protos * Add OneOf support, swap legacy for new event * Do not mix old and new events
codingllama
added a commit
that referenced
this pull request
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define a new base event for device trust, with the usual embeds of
StatusandUserMetadata.We can't swap the event in single PR as the code that issues it lives in e/, so it has to be done in multiple steps.
#25288