[Web] Add descriptions to session join modes menu#24961
Merged
Conversation
avatus
approved these changes
Apr 25, 2023
ryanclark
approved these changes
Apr 25, 2023
Merged
rudream
force-pushed
the
yassine/session-modes-redesign
branch
from
b9bafa6 to
fd9856f
Compare
Contributor
Author
Contributor
Technically it's a bit below contrast ratios recommended by WCAG AA standard, but text for disabled options often is. I'm good with it as is. |
rudream
force-pushed
the
yassine/session-modes-redesign
branch
from
fd9856f to
4c26c6f
Compare
rudream
added a commit
that referenced
this pull request
May 4, 2023
This was referenced May 4, 2023
pschisa
pushed a commit
that referenced
this pull request
May 4, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR closes #21208
Note: The linked issue mentions a tooltip, however we decided that instead of having a tooltip, we would have a short description under each mode that explains it instead.
Adds a short description under each participant mode that briefly describes its abilities. Also, participant modes that you don't have access to are no longer hidden but are now instead greyed out and have a disclaimer.
Notes
This design slightly deviates from the figma mockup in order to keep it more consistent with the rest of our design system (see our popover menus for connecting to Nodes, Desktops or AWS Console Apps).
Demo