Conversation
Merged
gzdunek
approved these changes
Apr 25, 2023
Contributor
gzdunek
left a comment
gzdunek
left a comment
There was a problem hiding this comment.
I found two small problems but other than that looks good.
ryanclark
approved these changes
Apr 25, 2023
public-teleport-github-review-bot
Bot
removed request for
ibeckermayer,
ravicious,
roraback and
zmb3
ravicious
reviewed
Apr 25, 2023
rudream
force-pushed
the
yassine/theme-fixes
branch
from
8879933 to
2230dc4
Compare
Contributor
Author
ryanclark
approved these changes
Apr 25, 2023
rudream
force-pushed
the
yassine/theme-fixes
branch
from
6e69485 to
ebcc213
Compare
rudream
force-pushed
the
yassine/theme-fixes
branch
from
1cc12f9 to
c8a5b7d
Compare
This was referenced Apr 26, 2023
rudream
added a commit
that referenced
this pull request
May 3, 2023
rudream
added a commit
that referenced
this pull request
May 3, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes some small issues related to the new theme changes that were discovered during the test plan.
ecounterpart: https://github.com/gravitational/teleport.e/pull/1204Implementation
text.mutedis now being used for the placeholder texts in forms, it is higher contrast than it used to be (24% -> 54%). This had to be done as the low opacity we used for our old placeholders was too low contrast and would fail contrast recommendations from WCAG.c650017 - Fixes the 'X' button being invisible in the default state on the event range picker calendar.
6d4e5d4 - The default button text opacity in the dark theme was 87% for some reason, this updates it to make it full opacity.
cbc78b6 - Adds more visible hover and focus button states for the Passwordless button in the Web UI and Connect.
a399059 - Fixes the title text colours in the AWS Console animated screens in dark theme. The background of those titles is dark, and when using light theme it was using the main text colour (black) and the text was blending in with the background.