[v11] Backport dronegen changes for GitHub Actions#24788
Merged
camscale merged 4 commits intobranch/v11from Apr 19, 2023
Merged
[v11] Backport dronegen changes for GitHub Actions#24788camscale merged 4 commits intobranch/v11from
camscale merged 4 commits intobranch/v11from
Conversation
Removes unnecessary workflow arguments from the Drone workflow invocation. Refactors some of the `dronegen` generators to make this easier to express insife `dronegen` This backports "Fix OCI promotion (#22867)" without the changes to the OCI pipelines as they have not been backported to v11.
Our ARM64 build fails quite frequently due to 30 minutes timeout. This PR increases the build timeout to one hour.
r0mant
reviewed
Apr 19, 2023
| cmd.WriteString(`-owner ${DRONE_REPO_OWNER} `) | ||
| cmd.WriteString(`-repo teleport.e `) | ||
| cmd.WriteString(`-tag-workflow `) | ||
| fmt.Fprintf(&cmd, `-timeout %s `, b.timeout.String()) |
Collaborator
There was a problem hiding this comment.
Did you run make dronegen? I see the timeout setting being added here but I don't see it anywhere in the .drone.yml in this changeset.
Contributor
Author
There was a problem hiding this comment.
Oops. Good catch. Fixed.
r0mant
approved these changes
Apr 19, 2023
tigrato
approved these changes
Apr 19, 2023
public-teleport-github-review-bot
Bot
removed request for
fheinecke,
tcsc and
wadells
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport a couple of partial PRs to more easily backport other changes
to branch/v11:
Ignore changes to the distroless OCI pipelines from those PRs as those
pipelines are not backported to
branch/v11. But we do want the othercode changes to dronegen.