Conversation
Removes unnecessary workflow arguments from the Drone workflow invocation. Refactors some of the `dronegen` generators to make this easier to express insife `dronegen`
r0mant
approved these changes
Mar 13, 2023
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
lgtm but I'd have @fheinecke look at it as well
fheinecke
approved these changes
Mar 13, 2023
public-teleport-github-review-bot
Bot
removed request for
ibeckermayer and
nklaassen
tcsc
added a commit
that referenced
this pull request
Mar 14, 2023
Removes unnecessary workflow arguments from the Drone workflow invocation. Refactors some of the `dronegen` generators to make this easier to express insife `dronegen`
tcsc
added a commit
that referenced
this pull request
Mar 14, 2023
* [v12] Backport Distroless OCI builds * [v12] Fix OCI promotion (#22867) Removes unnecessary workflow arguments from the Drone workflow invocation. Refactors some of the `dronegen` generators to make this easier to express insife `dronegen` * disable workflow tagging
camscale
pushed a commit
that referenced
this pull request
Apr 19, 2023
Removes unnecessary workflow arguments from the Drone workflow invocation. Refactors some of the `dronegen` generators to make this easier to express insife `dronegen` This backports "Fix OCI promotion (#22867)" without the changes to the OCI pipelines as they have not been backported to v11.
camscale
pushed a commit
that referenced
this pull request
Apr 19, 2023
Removes unnecessary workflow arguments from the Drone workflow invocation. Refactors some of the `dronegen` generators to make this easier to express insife `dronegen` This backports "Fix OCI promotion (#22867)" without the changes to the OCI pipelines as they have not been backported to v11.
camscale
added a commit
that referenced
this pull request
Apr 19, 2023
* [v11] Make GHA pipeline structure more generic Make the GHA pipeline structure generic instead of assuming it only calls the linux-arm64 workflows. This backports part of dff5cd4 from "Integrates distroless OCI publishing into drone (#22707)", but does not backport the distroless OCI pipelines themselves. * [v11] Removes unnecessary workflow arguments for GHA pipelines Removes unnecessary workflow arguments from the Drone workflow invocation. Refactors some of the `dronegen` generators to make this easier to express insife `dronegen` This backports "Fix OCI promotion (#22867)" without the changes to the OCI pipelines as they have not been backported to v11. * [v11] Increase GHA build timeout Our ARM64 build fails quite frequently due to 30 minutes timeout. This PR increases the build timeout to one hour. * Run dronegen for timeout params --------- Co-authored-by: Trent Clarke <trent@goteleport.com> Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
camscale
added a commit
that referenced
this pull request
Apr 20, 2023
* [v10] Make GHA pipeline structure more generic Make the GHA pipeline structure generic instead of assuming it only calls the linux-arm64 workflows. This backports part of dff5cd4 from "Integrates distroless OCI publishing into drone (#22707)", but does not backport the distroless OCI pipelines themselves. * [v10] Removes unnecessary workflow arguments for GHA pipelines Removes unnecessary workflow arguments from the Drone workflow invocation. Refactors some of the `dronegen` generators to make this easier to express insife `dronegen` This backports "Fix OCI promotion (#22867)" without the changes to the OCI pipelines as they have not been backported to v11. * [v10] Increase GHA build timeout Our ARM64 build fails quite frequently due to 30 minutes timeout. This PR increases the build timeout to one hour. * [v10] dronegen: Sort workflow inputs for stable output Sort the GitHub Actions inputs when generating the `gh-trigger-workflow` command line so that it does not randomly change order, as happens when iterating a map directly. This is a backport of a single commit of #24102 (drone: Switch Mac (darwin) pipelines to GitHub Actions), as it changes dronegen, but the pipelines themselves are not being backported to `branch/v10`. --------- Co-authored-by: Trent Clarke <trent@goteleport.com> Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unnecessary workflow arguments from the Drone workflow invocation.
Refactors some of the
dronegengenerators to make this easier to express insidedronegen