Skip to content

Fix vite development for desktop websocket endpoint #23815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibeckermayer merged 2 commits into from
Mar 30, 2023
Merged

Fix vite development for desktop websocket endpoint #23815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84785ad
sets changeOrigin to false
Mar 30, 2023
fa6477f
fixes README
Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions web/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ mkdir -p certs && mkcert -cert-file certs/server.crt -key-file certs/server.key
(Note: the `certs/` directory in this repo is ignored by git, so you can place your certificate/keys
in there without having to worry that they'll end up in a commit.)


#### Certificates in an alternative location

If you already have local certificates, you can set the environment variables:
Expand Down Expand Up @@ -218,7 +217,7 @@ proxy_service:
public_addr: ['proxy.127.0.0.1.nip.io']
```

Then start the dev server like `yarn start-teleport --target=https://proxy.127.0.0.1.nip.io:3080` and access it at https://proxy.127.0.0.1.nip.io:8080.
Then start the dev server like `PROXY_TARGET=https://proxy.127.0.0.1.nip.io:3080 yarn start-teleport` and access it at https://proxy.127.0.0.1.nip.io:8080.

### Adding Packages/Dependencies

Expand Down
2 changes: 1 addition & 1 deletion web/packages/build/vite/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export function createViteConfig(
config.server.proxy = {
'^\\/v1\\/webapi\\/sites\\/(.*?)\\/connect': {
target: `wss://${target}`,
changeOrigin: true,
changeOrigin: false,
secure: false,
ws: true,
},
Expand Down