[v7] Refactor Drone Pipelines to use AWS role assumption#17411
Merged
Conversation
This was referenced Oct 13, 2022
github-actions
Bot
requested review from
fheinecke,
justinas,
r0mant and
reedloden
r0mant
approved these changes
Oct 13, 2022
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
lgtm assuming you've tested it.
Removed for the following reasons: * We don't use a similar pattern with other volume refs * This removes the need to look in another file to determine what is going on * Adding them explicitly is fewer lines of code
wadells
force-pushed
the
walt/v7-role-assumption
branch
from
a946b39 to
ecb8988
Compare
Contributor
Author
Still working through that. I won't merge until I have a successful build and promote. |
reedloden
approved these changes
Oct 13, 2022
Contributor
Author
|
Tag & promote are clean -- merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #17201
Backports #17274
Backports #17314
Contributes to https://github.com/gravitational/SecOps/issues/213
There were a large range of merge conflicts during this port, including:
v9+ conflicts:
v7 specific conflicts:
Testing Done
Definitely needed given the wide array of merge conflicts.