Fix build-buildboxes timeouts#17314
Merged
Merged
Conversation
bd11a71 to
3e9cf26
Compare
reedloden
approved these changes
Oct 12, 2022
3e9cf26 to
1d80308
Compare
1178329 to
1c92f8b
Compare
This greatly reduces the number of steps in the pipeline, allowing drone-runner-kube to successfully schedule the pipeline. Fixes #17310 squash
This gives un-dronegen'ed pipelines the same syntax as dronegen'd ones, which is nice for consistency.
6ec4ba0 to
2760821
Compare
This was referenced Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As decribed in #17310, the build-buildboxes step was timing out due to a combination of too many steps and some drone inanity. This patch fixes the issue (and does a bit of tidying) by reducing the number of steps in the
build-buildboxespipeline. To do so, we now reusing long lived profiles instead of re-assuming multiple roles for every buildbox.Fixes #17310
Backports
Testing
https://drone.platform.teleport.sh/gravitational/teleport/16396
Performed with the following diff to get the pipeline to kick off: