Swap YUM_REPO_NEW_ROLE to YUM_REPO_NEW_AWS_ROLE#17406
Closed
wadells wants to merge 2 commits into
Closed
Conversation
All other roles environment variables end in AWS_ROLE, and consistency is our friend here.
This was referenced Oct 13, 2022
reedloden
approved these changes
Oct 13, 2022
fheinecke
approved these changes
Oct 14, 2022
r0mant
approved these changes
Oct 18, 2022
This was referenced Oct 20, 2022
Contributor
Author
|
This change will be merged in #17638 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't fix anything broken -- it updates our drone variables to be more consistent.
All other drone role environment variables end in
AWS_ROLE. I typoedYUM_REPO_NEW_ROLEduring #17201, and fixed it by duplicating the environment variable in https://github.com/gravitational/ops/pull/436. I'll undo https://github.com/gravitational/ops/pull/436 once this is available in all branches.Backports
Testing
None -- this is simple enough I feel ok skipping a dev build. It is also already working on v9 and v8.