APT/YUM publishing fixes#17638
Merged
Merged
Conversation
r0mant
approved these changes
Oct 20, 2022
wadells
force-pushed
the
walt/fix-yum-race
branch
from
ec60607 to
29bc558
Compare
This was referenced Oct 21, 2022
Collaborator
|
@wadells Why did the |
Contributor
Author
Network Timeout: I didn't touch the AMI pipelines, so this is unrelated to my changes. Nonetheless, since I'm waiting on other tests to merge, I'll go ahead and re-run this dev build and promote, to get a green build on these steps as well. Tag: https://drone.platform.teleport.sh/gravitational/teleport/16757 |
These were running in parallel, but we want them to run serially. Therefore, we add a dependency between each step and its previous step.
This helps test a couple more changes from this pipeline when cutting a dev build. Particularly, we saw the download and role assumption steps fail in #17334, and this change would have allowed us to catch that error during testing.
This bug does not appear to affect anything currently. However it should be fixed in case the rm is important at some point in the future. The bug is: when a wildcard is inside quotes, it is treated as a literal filename. So rm -rf "$ARTIFACT_PATH/*" tries to remove the file named '*' instead of trying to remove everything in artifact path.
All other roles environment variables end in AWS_ROLE, and consistency is our friend here.
wadells
force-pushed
the
walt/fix-yum-race
branch
from
29bc558 to
aad6822
Compare
reedloden
approved these changes
Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a variety of fixes and improvements to our apt & yum promotion pipelines. These are broken out by commit:
Serialize apt/yum promote pipelinesfixes the errors seen in https://drone.platform.teleport.sh/gravitational/teleport/16694/1/5 by serializing pipeline steps via dependencies.Allow dev build promotes to proceed in deb/rpm pipelinesallows us to test the fix above, which was formerly skipped on promotes of dev builds. This is the future of the changes proposed in Allow dev build promotes to proceed in deb/rpm pipelines #17340Fix globbing bugfixes a seemingly harmless globbing bug. This was opportunistic cleanup.Swap YUM_REPO_NEW_ROLE to YUM_REPO_NEW_AWS_ROLEintroduces the changes from Swap YUM_REPO_NEW_ROLE to YUM_REPO_NEW_AWS_ROLE #17406, in case this lands first.Backports
Testing
I won't merge until these are both green.