Fix apt/rpm publishing issues#16991
Merged
Merged
Conversation
Without these changes, the promote step will always fail because of a mismatch between where the repo is cloned and where it is referenced: /go/src/.../teleport.git vs /go/src/.../teleport (cherry picked from commit b209b98)
Without this any tag that isn't part of the history on master will fail to successfully promote. This breaks most dev builds, which don't end up as part of master or a release branch.
fheinecke
approved these changes
Oct 4, 2022
r0mant
approved these changes
Oct 4, 2022
This was referenced Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
--tagsto a git pull, without this dev builds will fail to promote witherror: pathspec 'v10.3.2-dev-walt.1' did not match any file(s) known to gitas seen in https://drone.platform.teleport.sh/gravitational/teleport/16100/1/2The
--tagslogic needs backporting through v8, The forwardport is already present everywhere but master.Testing Done
Underway. See the following builds which include the fixes herein as well as the fixes in #16986, since I need both for a successful promote.