Remove old promote step#16986
Merged
Merged
Conversation
wadells
approved these changes
Oct 4, 2022
Collaborator
|
@Joerger are we okay with the |
r0mant
requested changes
Oct 4, 2022
| - cd $WORKSPACE_DIR/go/src/github.com/gravitational/teleport | ||
| - build.assets/build-fido2-macos.sh build | ||
| - export PKG_CONFIG_PATH="$(build.assets/build-fido2-macos.sh pkg_config_path)" | ||
| - make clean release OS=$OS ARCH=$ARCH FIDO2=yes TOUCHID=yes LIBPCSCLITE=yes |
Collaborator
There was a problem hiding this comment.
Why was LIBPCSCLITE=yes removed here and below? cc @jakule
Contributor
Author
There was a problem hiding this comment.
Please see #15874 where this value was updated in dronegen/mac.go but was not updated in the .drone.yml file via make dronegen.
Collaborator
Contributor
There was a problem hiding this comment.
Yes this is correct, sorry for the confusion.
Joerger
approved these changes
Oct 4, 2022
r0mant
approved these changes
Oct 4, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a step from drone that is now failing in v11 promotion events. See https://drone.platform.teleport.sh/gravitational/teleport/16096/5/5 for the failing drone example.
It also includes a change to
mac.goin dronegen that was added to dronegen but not updated through a call tomake dronegen. See #15874Credit to @wadells for finding the issue.
Testing
https://drone.platform.teleport.sh/gravitational/teleport/16121/5/1