[v8] Fetch tags when promoting rpm/deb#17034
Merged
Merged
Conversation
zmb3
approved these changes
Oct 7, 2022
Collaborator
zmb3
left a comment
zmb3
left a comment
There was a problem hiding this comment.
Approved but double check the signature since I think .drone.yml has gone out of date.
Contributor
Author
Yeah -- I'll rebase right before merge. I don't typically bother to keep the signature up to date until they're approved, as it is a bunch of busy work for no gain. |
reedloden
approved these changes
Oct 8, 2022
Without this any tag that isn't part of the history on master will fail to successfully promote. This breaks most dev builds, which don't end up as part of master or a release branch. (cherry picked from commit 531bc51)
reedloden
force-pushed
the
walt/v8-fix-dev-build-promotion
branch
from
901c8ec to
fd652bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #16991 to branch/v8 (at least the parts of it that weren't already in v8)
This is as far back as the changes need to go, as the new apt/deb publishing pipelines do not appear to be in v7.
Without this any tag that isn't part of the history on the release branch will fail to successfully promote. This breaks most dev builds, which don't end up as part of master or a release branch. See https://drone.platform.teleport.sh/gravitational/teleport/16103 for an example failure.
(cherry picked from commit 531bc51)