FileFullDirectoryInformation#12908
Merged
ibeckermayer merged 147 commits intowindows-desktop-directory-sharingfrom Jun 28, 2022
Merged
FileFullDirectoryInformation#12908ibeckermayer merged 147 commits intowindows-desktop-directory-sharingfrom
FileFullDirectoryInformation#12908ibeckermayer merged 147 commits intowindows-desktop-directory-sharingfrom
Conversation
added 30 commits
March 31, 2022 15:35
…and cliprdr::Client's have the vchan::Client as a field.
…o trigger it by right-clicking, however it isn't working. One reason is that the vchannel PDU header isn't being added (see rdpdr::encode_message for how that's added to other messages). Noticing that made me notice that there is another cliprdr function for breaking outgoing messages into chunks that should be refactored into vchan to do that work + add the necessary vchan headers. This is a checkpoint commit while I go attend to that.
…lient parses the DeviceCreateRequest that's immediately sent back
…ugh in most cases, no need to neurotically add every bit of the documentation text to the code itself
LKozlowski
approved these changes
May 26, 2022
Contributor
LKozlowski
left a comment
LKozlowski
left a comment
There was a problem hiding this comment.
I don't have any other comments other than what Joel already said.
Collaborator
|
Context is king - any information you can add to the PR description will be helpful for reviewers. What does "FileFullDirectoryInformation support" mean and why do we need it? |
zmb3
requested changes
Jun 13, 2022
Comment on lines
+2090
to
+2091
| /// 4 u32's (including FileAttributesFlags) + 6 i64's | ||
| const FILE_FULL_DIRECTORY_INFORMATION_BASE_SIZE: u32 = (5 * 4) + (6 * 8); // 68 |
Collaborator
There was a problem hiding this comment.
4 u32s and 6 i64s would be 4 * 4 + 6 * 8 = 16 + 48 = 64 so this looks wrong to me.
Contributor
Author
There was a problem hiding this comment.
Changed the comment to what is should be:
/// 5 u32's (including FileAttributesFlags) + 6 i64's
added 8 commits
June 14, 2022 17:53
…sefully pedantic copies to Rust owned memory in relevant FFI functions
added 2 commits
June 28, 2022 12:15
Contributor
Author
Updated the description with some more context: #12908 (comment) |
zmb3
approved these changes
Jun 28, 2022
ibeckermayer
changed the base branch from
isaiah/irp-mj-directory-control
to
windows-desktop-directory-sharing
…DirectoryInformation
ibeckermayer
pushed a commit
that referenced
this pull request
Jul 6, 2022
ibeckermayer
pushed a commit
that referenced
this pull request
Jul 13, 2022
ibeckermayer
pushed a commit
that referenced
this pull request
Aug 23, 2022
* `IRP_MJ_CREATE` (#12665) * `IRP_MJ_QUERY_INFORMATION` (#12717) * `IRP_MJ_CLOSE` (#12729) * Refactor rdpdr client (#12750) * Adding logic for `FILE_SUPERSEDE` (#12829) * Improve `process_irp_create` (#12830) * adds return statements that got lost in a merge * `IRP_MJ_DIRECTORY_CONTROL` (#12870) * `FileFullDirectoryInformation` (#12908) * Improve `ClientDriveQueryDirectoryResponse.encode()` (#12912) * `IRP_MJ_QUERY_VOLUME_INFORMATION` (#13071) * Fix Shared Directory Request handling when feature is disabled (#13439) * IRP_MJ_READ, IRP_MJ_WRITE, and IRP_MJ_SET_INFORMATION (#13995) * Adds constants for sizing calculations (#14051) Co-authored-by: Łukasz Kozłowski <lukasz.kozlowski@goteleport.com> Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
ibeckermayer
pushed a commit
that referenced
this pull request
Aug 23, 2022
* `IRP_MJ_CREATE` (#12665) * `IRP_MJ_QUERY_INFORMATION` (#12717) * `IRP_MJ_CLOSE` (#12729) * Refactor rdpdr client (#12750) * Adding logic for `FILE_SUPERSEDE` (#12829) * Improve `process_irp_create` (#12830) * adds return statements that got lost in a merge * `IRP_MJ_DIRECTORY_CONTROL` (#12870) * `FileFullDirectoryInformation` (#12908) * Improve `ClientDriveQueryDirectoryResponse.encode()` (#12912) * `IRP_MJ_QUERY_VOLUME_INFORMATION` (#13071) * Fix Shared Directory Request handling when feature is disabled (#13439) * IRP_MJ_READ, IRP_MJ_WRITE, and IRP_MJ_SET_INFORMATION (#13995) * Adds constants for sizing calculations (#14051) Co-authored-by: Łukasz Kozłowski <lukasz.kozlowski@goteleport.com> Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
ibeckermayer
pushed a commit
that referenced
this pull request
Sep 7, 2022
…ring) (#15770) * Windows Desktop Directory Sharing (#13630) * `IRP_MJ_CREATE` (#12665) * `IRP_MJ_QUERY_INFORMATION` (#12717) * `IRP_MJ_CLOSE` (#12729) * Refactor rdpdr client (#12750) * Adding logic for `FILE_SUPERSEDE` (#12829) * Improve `process_irp_create` (#12830) * adds return statements that got lost in a merge * `IRP_MJ_DIRECTORY_CONTROL` (#12870) * `FileFullDirectoryInformation` (#12908) * Improve `ClientDriveQueryDirectoryResponse.encode()` (#12912) * `IRP_MJ_QUERY_VOLUME_INFORMATION` (#13071) * Fix Shared Directory Request handling when feature is disabled (#13439) * IRP_MJ_READ, IRP_MJ_WRITE, and IRP_MJ_SET_INFORMATION (#13995) * Adds constants for sizing calculations (#14051) Co-authored-by: Łukasz Kozłowski <lukasz.kozlowski@goteleport.com> Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * `UnixPath` and `WindowsPath` (#14267) * `SharedDirectoryMoveRequest` and `SharedDirectoryMoveResponse` (#14959) * `SharedDirectoryCreateResponse` update (#15289) * Fix `process_irp_set_information` (#15364) * Sanitize Rust Debug Logs (#15743) * updates rdp-rs ref to include licensing changes * Updates rdp-rs ref and fixes Cargo Co-authored-by: Łukasz Kozłowski <lukasz.kozlowski@goteleport.com> Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
FileFullDirectoryInformationsupport, which I encountered while debugging on more advanced version of theisaiah/simulate-shared-directorywebappsbranch (not yet merged).FileFullDirectoryInformationis an RDP data structure that we need to send back to the RDP server when we receive aServerDriveQueryDirectoryRequestwith it'sfs_information_class_lvlset toFsInformationClassLevel::FileFullDirectoryInformation