Changes for tctl sso test, tctl sso configure commands [SAML]#11508
Merged
Conversation
Contributor
Author
|
Dear reviewers, but especially @r0mant @smallinsky : please take a close look at the security angle, including the topics mentioned in the respective RFDs. Thanks! |
Tener
changed the title
smallinsky
reviewed
Apr 4, 2022
Contributor
smallinsky
left a comment
smallinsky
left a comment
There was a problem hiding this comment.
First pass, Left some comments.
Contributor
Author
@r0mant thanks for the review, I'll add test coverage next. |
Co-authored-by: Roman Tkachenko <roman@goteleport.com>
- Rename auth.AssertionInfoWrapper to shorter auth.AssertionInfo. - Add bool TestFlow to SSODiagnosticInfo - Make SSODiagnosticInfo.Success a bool instead of string. - Rename SAMLAttributesToRolesWarnings to more generic SSOWarnings - Add godocs in several places. - Avoid explicit call to trace.AddUserMessage() where possible.
Contributor
Author
|
@r0mant I've added test coverage for the critical pieces. Let me know if you'd like me to add more coverage anywhere. |
Contributor
Author
Awesome, thanks for approval. @smallinsky PTAL? |
smallinsky
approved these changes
May 4, 2022
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are necessary changes to support
tctl sso testand (to a much smaller degree)tctl sso configurecommand.RFD:
tctl sso configurecommand: #9845RFD:
tctl sso testcommand: #9775See: #9270 for original issue, which covers larger scope: SAML, OIDC and GitHub auth connectors. This PR is only touching on SAML, but the implementations for OIDC and GitHub should be parallel to this one.
Actual commands for SAML are implemented in: https://github.com/gravitational/teleport.e/pull/425
Webapps PR: gravitational/webapps#717