Skip to content

Changes for tctl sso test, tctl sso configure commands [OIDC]#12519

Merged
Tener merged 18 commits into
masterfrom
tener/tctl-sso-oidc
May 17, 2022
Merged

Changes for tctl sso test, tctl sso configure commands [OIDC]#12519
Tener merged 18 commits into
masterfrom
tener/tctl-sso-oidc

Conversation

@Tener
Copy link
Copy Markdown
Contributor

@Tener Tener commented May 9, 2022

Follow up to #11508, OIDC coverage for tctl sso test and tctl sso configure.

RFD: tctl sso configure command: https://github.com/gravitational/teleport/blob/master/rfd/0070-tctl-sso-configure-command.md
RFD: tctl sso test command: https://github.com/gravitational/teleport/blob/master/rfd/0071-tctl-sso-test-command.md

See: #9270 for original issue. This PR covers OIDC part of the issue. GitHub coverage PR to follow.

PR for updated commands: https://github.com/gravitational/teleport.e/pull/434

@github-actions github-actions Bot requested review from rosstimothy and xacrimon May 9, 2022 12:44
@github-actions github-actions Bot added the rfd Request for Discussion label May 9, 2022
@Tener Tener requested review from r0mant and smallinsky May 9, 2022 13:00
@Tener Tener changed the title Changes for tctl sso test, tctl sso configure commands [OIDC] Changes for tctl sso test, tctl sso configure commands [OIDC] May 9, 2022
@Tener Tener requested a review from espadolini May 9, 2022 13:02
@Tener Tener self-assigned this May 9, 2022
Comment thread api/types/types.proto
Comment thread lib/auth/auth_with_roles_test.go
Comment thread lib/auth/oidc.go
Copy link
Copy Markdown
Contributor

@smallinsky smallinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First iteration.

Comment thread api/types/oidc_external.go
Comment thread lib/auth/oidc.go Outdated
Comment thread api/types/types.proto
Comment thread api/types/oidc_external.go Outdated
@Tener Tener requested review from rosstimothy and smallinsky May 16, 2022 06:53
@Tener
Copy link
Copy Markdown
Contributor Author

Tener commented May 16, 2022

Kind reminder @r0mant

Comment thread lib/auth/oidc.go Outdated
@Tener Tener enabled auto-merge (squash) May 17, 2022 16:17
@Tener Tener merged commit 414c82a into master May 17, 2022
@Tener Tener deleted the tener/tctl-sso-oidc branch July 22, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfd Request for Discussion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants