Skip to content

RFD: tctl sso configure command.#9845

Merged
Tener merged 10 commits into
masterfrom
tener/rfd-sso-configure
Apr 22, 2022
Merged

RFD: tctl sso configure command.#9845
Tener merged 10 commits into
masterfrom
tener/rfd-sso-configure

Conversation

@Tener
Copy link
Copy Markdown
Contributor

@Tener Tener commented Jan 19, 2022

This RFD is "implement auth connector configurator" part of #9270.

@Tener Tener requested a review from r0mant January 19, 2022 17:26
Comment thread rfd/0049-sso-configure-command.md Outdated
Comment thread rfd/0049-sso-configure-command.md Outdated
Comment thread rfd/0049-sso-configure-command.md Outdated
Comment thread rfd/0049-sso-configure-command.md Outdated
Comment thread rfd/0049-sso-configure-command.md Outdated
Comment thread rfd/0049-sso-configure-command.md Outdated
Comment thread rfd/0049-sso-configure-command.md Outdated
@Tener Tener marked this pull request as ready for review January 26, 2022 13:20
@github-actions github-actions Bot added the rfd Request for Discussion label Jan 26, 2022
Tener added 3 commits March 29, 2022 12:20
- The "interactive" mode is discarded.
- The SAML section describes flags and examples.
- Rephrased, updated other sections.
@Tener
Copy link
Copy Markdown
Contributor Author

Tener commented Mar 29, 2022

@xinding33 @r0mant @smallinsky

Please take a look at this updated version.

Copy link
Copy Markdown
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with the comment about flags.

Comment thread rfd/0062-tctl-sso-configure-command.md Outdated
@r0mant
Copy link
Copy Markdown
Collaborator

r0mant commented Apr 12, 2022

@xinding33 Can you give this another quick look from the UX perspective and approve if it looks good so we can merge it? This basically describes the same tctl sso configure command we saw on a demo a couple weeks ago.

Comment thread rfd/0062-tctl-sso-configure-command.md Outdated
Comment thread rfd/00XX-tctl-sso-configure-command.md
@Tener Tener merged commit 966dabb into master Apr 22, 2022
@Tener Tener deleted the tener/rfd-sso-configure branch April 22, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfd Request for Discussion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants