This repository was archived by the owner on Jun 4, 2024. It is now read-only.
Refactor Drone Pipelines to use AWS role assumption#671
Merged
Conversation
reedloden
reviewed
Sep 29, 2022
wadells
force-pushed
the
walt/drone-role-refactor
branch
from
d38c845 to
7470b8b
Compare
wadells
requested review from
Joerger,
klizhentas,
r0mant,
russjones,
tcsc and
zmb3
as code owners
reedloden
approved these changes
Sep 30, 2022
logand22
approved these changes
Oct 3, 2022
hugoShaka
approved these changes
Oct 3, 2022
Joerger
approved these changes
Oct 5, 2022
wadells
force-pushed
the
walt/drone-role-refactor
branch
2 times, most recently
from
edcc1a3 to
7261c99
Compare
Contributor
Author
|
Update: With the new roles available (https://github.com/gravitational/ops/pull/432), I've completed testing both tag builds and promotion with the Tag Builds:
Promotion: |
Our AWS FTR requires that we do not use any long lived credentials in our AWS accounts and instead use roles. This means we need to move from attaching policies to users to attaching policies to roles and having permissionless users assume those roles. https://aws.amazon.com/partners/foundational-technical-review/ We created the roles needed in: https://github.com/gravitational/cloud-terraform/pull/944 https://github.com/gravitational/cloud-terraform/pull/956 This PR updates the automation to use these roles, such that we can later remove the policies from the users. Contributes to https://github.com/gravitational/SecOps/issues/213
This is unneeded, since these steps are already in a helm specific pipeline. This naming was a hold over from the oldest teleport promotion pipelines, where multiple different artifacts were promoted in the same pipeline.
wadells
force-pushed
the
walt/drone-role-refactor
branch
from
7261c99 to
32874dc
Compare
wadells
added a commit
that referenced
this pull request
Oct 6, 2022
Our AWS FTR requires that we do not use any long lived credentials in our AWS accounts and instead use roles. This means we need to move from attaching policies to users to attaching policies to roles and having permissionless users assume those roles. https://aws.amazon.com/partners/foundational-technical-review/ We created the roles needed in: https://github.com/gravitational/cloud-terraform/pull/944 https://github.com/gravitational/cloud-terraform/pull/956 This PR updates the automation to use these roles, such that we can later remove the policies from the users. Contributes to https://github.com/gravitational/SecOps/issues/213
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates our various Drone pipelines to use AWS roles for publishing.
Our AWS FTR requires that we do not use any long lived credentials in our AWS accounts and instead use roles. This means we need to move from attaching policies directly to users to attaching policies to roles and having policyless users assume those roles.
We created the roles needed in:
https://github.com/gravitational/cloud-terraform/pull/944
https://github.com/gravitational/cloud-terraform/pull/956
And added them to Drone in:
https://github.com/gravitational/ops/pull/432
This PR updates the automation to use the new roles, such that we can later remove the policies from the users.
Contributes to https://github.com/gravitational/SecOps/issues/213
Testing Done
See this comment below:
#671 (comment)
I also proved out the same logic in several less critical places:
Notes to the reviewer
This is largely rote. One linux pipline is like any other. The places to pay attention are:
Lastly, I didn't change anything about the terraform promotion pipeline, as it already appears to be using a role, plumbed through some custom go code.