This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Refactor publishing to use AWS roles#891
Merged
Merged
Conversation
Instead of directly using a token associated with a long lived AWS user, we now use this token to assume a short lived role. The publishing logic has no access to the long lived credentials, and only uses the short lived role. Contributes to https://github.com/gravitational/SecOps/issues/213
wadells
requested review from
a team,
adaadb6,
bernardjkim,
bpdohall and
reedloden
reedloden
approved these changes
Sep 29, 2022
bernardjkim
approved these changes
Sep 29, 2022
wadells
added a commit
that referenced
this pull request
Sep 29, 2022
Instead of directly using a token associated with a long lived AWS user, we now use this token to assume a short lived role. The publishing logic has no access to the long lived credentials, and only uses the short lived role. Contributes to https://github.com/gravitational/SecOps/issues/213 (cherry picked from commit d995ead)
wadells
added a commit
that referenced
this pull request
Sep 29, 2022
Instead of directly using a token associated with a long lived AWS user, we now use this token to assume a short lived role. The publishing logic has no access to the long lived credentials, and only uses the short lived role. Contributes to https://github.com/gravitational/SecOps/issues/213 (cherry picked from commit d995ead)
This was referenced Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of directly using a token associated with a long lived AWS user, we now use this token to assume a short lived role. The publishing logic has no access to the long lived credentials, and only uses the short lived role.
Uses the role provisioned in https://github.com/gravitational/cloud-terraform/pull/944
Uses the credentials provisioned in https://github.com/gravitational/cloud-terraform/pull/957
Contributes to https://github.com/gravitational/SecOps/issues/213
Testing Done
I published the tag
7.0.68-11709-dev.1using this logic. See:https://drone.platform.teleport.sh/gravitational/planet/158/1/4
I since deleted this tag, as it should have been a 9.0.0 tag 🤦