Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default value for argument should be Undefined (Issue #1394) #1412

Merged

Conversation

tcleonard
Copy link
Collaborator

@tcleonard tcleonard commented Mar 20, 2022

@tcleonard tcleonard force-pushed the issue-#1394_fix-required branch from e0c3fdb to 19ebf08 Compare March 20, 2022 17:49
tcleonard pushed a commit to loft-orbital/graphene-django that referenced this pull request Mar 20, 2022
tcleonard pushed a commit to loft-orbital/graphene-django that referenced this pull request Mar 20, 2022
tcleonard pushed a commit to loft-orbital/graphene-django that referenced this pull request Mar 20, 2022
tcleonard pushed a commit to loft-orbital/graphene-django that referenced this pull request Mar 20, 2022
tcleonard pushed a commit to loft-orbital/graphene-django that referenced this pull request Mar 20, 2022
@stabacco
Copy link

A similar fix was provided in #1399 which has been sitting there for a long time unfortunately. Not sure who's supposed to have a look at these but it'd be great if someone could.
This issue is currently holding us back from being able to upgrade all our gql stack.

Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkimbo jkimbo merged commit 03277a5 into graphql-python:master Apr 7, 2022
@tcleonard tcleonard deleted the issue-#1394_fix-required branch June 20, 2022 13:39
firaskafri pushed a commit to graphql-python/graphene-django that referenced this pull request Sep 23, 2022
* Issue #1111: foreign key should also call get_queryset method

* fix: test for graphene PR graphql-python/graphene#1412

Co-authored-by: Thomas Leonard <[email protected]>
VV-YY added a commit to VV-YY/graphene-django that referenced this pull request Jan 18, 2023
* Issue #1111: foreign key should also call get_queryset method

* fix: test for graphene PR graphql-python/graphene#1412

Co-authored-by: Thomas Leonard <[email protected]>
ipyramiddev added a commit to ipyramiddev/graphene-api-django that referenced this pull request Mar 22, 2023
* Issue #1111: foreign key should also call get_queryset method

* fix: test for graphene PR graphql-python/graphene#1412

Co-authored-by: Thomas Leonard <[email protected]>
paxaxel223 added a commit to paxaxel223/graphe-django that referenced this pull request Apr 25, 2023
* Issue #1111: foreign key should also call get_queryset method

* fix: test for graphene PR graphql-python/graphene#1412

Co-authored-by: Thomas Leonard <[email protected]>
igodev0001 pushed a commit to igodev0001/graphene-django that referenced this pull request Jul 4, 2023
* Issue #1111: foreign key should also call get_queryset method

* fix: test for graphene PR graphql-python/graphene#1412

Co-authored-by: Thomas Leonard <[email protected]>
DevStar1016 added a commit to DevStar1016/graphine-django that referenced this pull request Sep 11, 2023
* Issue #1111: foreign key should also call get_queryset method

* fix: test for graphene PR graphql-python/graphene#1412

Co-authored-by: Thomas Leonard <[email protected]>
code-worm19 added a commit to code-worm19/graphene-api-django that referenced this pull request Jan 23, 2025
* Issue #1111: foreign key should also call get_queryset method

* fix: test for graphene PR graphql-python/graphene#1412

Co-authored-by: Thomas Leonard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants