-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: default value for argument should be Undefined (Issue #1394) #1412
Merged
jkimbo
merged 1 commit into
graphql-python:master
from
loft-orbital:issue-#1394_fix-required
Apr 7, 2022
Merged
fix: default value for argument should be Undefined (Issue #1394) #1412
jkimbo
merged 1 commit into
graphql-python:master
from
loft-orbital:issue-#1394_fix-required
Apr 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tcleonard
commented
Mar 20, 2022
•
edited
Loading
edited
- Fix issue Required/NonNull parameters do not work #1394
- Fix test from master due to a change of global ID parsing in graphql relay
…thon#1394) and update function from_global_id exception handling (graphql-python/graphql-relay-py@b217aef)
tcleonard
force-pushed
the
issue-#1394_fix-required
branch
from
March 20, 2022 17:49
e0c3fdb
to
19ebf08
Compare
tcleonard
pushed a commit
to loft-orbital/graphene-django
that referenced
this pull request
Mar 20, 2022
This was referenced Mar 20, 2022
tcleonard
pushed a commit
to loft-orbital/graphene-django
that referenced
this pull request
Mar 20, 2022
tcleonard
pushed a commit
to loft-orbital/graphene-django
that referenced
this pull request
Mar 20, 2022
tcleonard
pushed a commit
to loft-orbital/graphene-django
that referenced
this pull request
Mar 20, 2022
tcleonard
pushed a commit
to loft-orbital/graphene-django
that referenced
this pull request
Mar 20, 2022
A similar fix was provided in #1399 which has been sitting there for a long time unfortunately. Not sure who's supposed to have a look at these but it'd be great if someone could. |
jkimbo
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4 tasks
firaskafri
pushed a commit
to graphql-python/graphene-django
that referenced
this pull request
Sep 23, 2022
* Issue #1111: foreign key should also call get_queryset method * fix: test for graphene PR graphql-python/graphene#1412 Co-authored-by: Thomas Leonard <[email protected]>
VV-YY
added a commit
to VV-YY/graphene-django
that referenced
this pull request
Jan 18, 2023
* Issue #1111: foreign key should also call get_queryset method * fix: test for graphene PR graphql-python/graphene#1412 Co-authored-by: Thomas Leonard <[email protected]>
ipyramiddev
added a commit
to ipyramiddev/graphene-api-django
that referenced
this pull request
Mar 22, 2023
* Issue #1111: foreign key should also call get_queryset method * fix: test for graphene PR graphql-python/graphene#1412 Co-authored-by: Thomas Leonard <[email protected]>
paxaxel223
added a commit
to paxaxel223/graphe-django
that referenced
this pull request
Apr 25, 2023
* Issue #1111: foreign key should also call get_queryset method * fix: test for graphene PR graphql-python/graphene#1412 Co-authored-by: Thomas Leonard <[email protected]>
igodev0001
pushed a commit
to igodev0001/graphene-django
that referenced
this pull request
Jul 4, 2023
* Issue #1111: foreign key should also call get_queryset method * fix: test for graphene PR graphql-python/graphene#1412 Co-authored-by: Thomas Leonard <[email protected]>
DevStar1016
added a commit
to DevStar1016/graphine-django
that referenced
this pull request
Sep 11, 2023
* Issue #1111: foreign key should also call get_queryset method * fix: test for graphene PR graphql-python/graphene#1412 Co-authored-by: Thomas Leonard <[email protected]>
code-worm19
added a commit
to code-worm19/graphene-api-django
that referenced
this pull request
Jan 23, 2025
* Issue #1111: foreign key should also call get_queryset method * fix: test for graphene PR graphql-python/graphene#1412 Co-authored-by: Thomas Leonard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.