Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1413 fix invalid input type #1414

Conversation

tcleonard
Copy link
Collaborator

@tcleonard tcleonard commented Mar 20, 2022

The failure in the CI exists on master as well.
You can find the fix on the PR #1412

@tcleonard tcleonard force-pushed the issue-#1413_fix-invalid-input-type branch 2 times, most recently from daf66f1 to 375e600 Compare March 20, 2022 20:22
Copy link
Member

@erikwrede erikwrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, looks good to me!

graphene/types/json.py Outdated Show resolved Hide resolved
@tcleonard tcleonard force-pushed the issue-#1413_fix-invalid-input-type branch 3 times, most recently from 7d37e64 to 06808be Compare June 20, 2022 12:59
@tcleonard tcleonard force-pushed the issue-#1413_fix-invalid-input-type branch from 06808be to 3bdc67c Compare June 20, 2022 13:15
Copy link
Member

@erikwrede erikwrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erikwrede erikwrede merged commit 23ca978 into graphql-python:master Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants