Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(framework-tests): add graphene framework test #3646

Merged
merged 2 commits into from
May 6, 2022
Merged

ci(framework-tests): add graphene framework test #3646

merged 2 commits into from
May 6, 2022

Conversation

mabdinur
Copy link
Contributor

Tests ddtrace compatibility with graphene v3.0

  • ddtrace graphql-core integration will be released in a future PR

Checklist

  • Added to the correct milestone.
  • Tests provided or description of manual testing performed is included in the code or PR.
  • Library documentation is updated.
  • Corp site documentation is updated (link to the PR).

@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 28, 2022
Kyle-Verhoog
Kyle-Verhoog reviewed Apr 28, 2022
View reviewed changes
.github/workflows/test_frameworks.yml Outdated Show resolved Hide resolved
.github/workflows/test_frameworks.yml Outdated Show resolved Hide resolved
.github/workflows/test_frameworks.yml Outdated Show resolved Hide resolved
@mabdinur mabdinur force-pushed the munir/add-graphne-framework-test branch 4 times, most recently from fd96c2e to f2a34c9 Compare April 29, 2022 16:16
@mabdinur mabdinur marked this pull request as ready for review April 29, 2022 18:31
@mabdinur mabdinur requested a review from a team as a code owner April 29, 2022 18:31
Kyle-Verhoog
Kyle-Verhoog reviewed Apr 29, 2022
View reviewed changes
.github/workflows/test_frameworks.yml Outdated Show resolved Hide resolved
.github/workflows/test_frameworks.yml Outdated Show resolved Hide resolved
@mabdinur mabdinur force-pushed the munir/add-graphne-framework-test branch 2 times, most recently from 129f9b3 to d576e37 Compare April 29, 2022 22:28
jd
jd previously requested changes May 1, 2022
View reviewed changes
.github/workflows/test_frameworks.yml Outdated Show resolved Hide resolved
@P403n1x87 P403n1x87 changed the title ci(graphne): add graphne framework test ci(graphene): add graphene framework test May 3, 2022
Kyle-Verhoog
Kyle-Verhoog requested changes May 3, 2022
View reviewed changes
ddtrace/contrib/botocore/patch.py Outdated Show resolved Hide resolved
@mabdinur mabdinur force-pushed the munir/add-graphne-framework-test branch 3 times, most recently from d3b8aeb to 4d06b27 Compare May 5, 2022 14:16
@mabdinur mabdinur requested review from Kyle-Verhoog, P403n1x87 and jd May 5, 2022 14:17
Kyle-Verhoog
Kyle-Verhoog previously approved these changes May 6, 2022
View reviewed changes
.github/workflows/test_frameworks.yml Outdated Show resolved Hide resolved
Kyle-Verhoog
Kyle-Verhoog previously approved these changes May 6, 2022
View reviewed changes
@Kyle-Verhoog Kyle-Verhoog dismissed jd’s stale review May 6, 2022 14:23

addressed

@mabdinur mabdinur force-pushed the munir/add-graphne-framework-test branch from 431a58a to 30545b9 Compare May 6, 2022 15:22
@mabdinur mabdinur force-pushed the munir/add-graphne-framework-test branch from 30545b9 to d23d9c4 Compare May 6, 2022 15:23
@mabdinur mabdinur requested a review from Kyle-Verhoog May 6, 2022 17:23
@majorgreys majorgreys changed the title ci(graphene): add graphene framework test ci(framework-tests): add graphene framework test May 6, 2022
@Kyle-Verhoog Kyle-Verhoog merged commit 50add6c into 1.x May 6, 2022
@Kyle-Verhoog Kyle-Verhoog deleted the munir/add-graphne-framework-test branch May 6, 2022 18:32
@github-actions github-actions bot added this to the v1.2.0 milestone May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majorgreys majorgreys majorgreys approved these changes

@Kyle-Verhoog Kyle-Verhoog Kyle-Verhoog approved these changes

@P403n1x87 P403n1x87 Awaiting requested review from P403n1x87

@jd jd Awaiting requested review from jd

Assignees
No one assigned
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mabdinur @jd @majorgreys @Kyle-Verhoog @P403n1x87