fix: add 'mise run fix' hint to lint failure output by zeitlinger · Pull Request #90 · grafana/flint

zeitlinger · 2026-03-03T11:33:31Z

When a lint task fails, print a hint suggesting mise run fix to help users discover the autofix workflow. The hint is suppressed during AUTOFIX mode to avoid circular advice.

Closes #89

When a lint task fails, print a hint suggesting `mise run fix` to help users discover the autofix workflow. The hint is suppressed during AUTOFIX mode to avoid circular advice. Closes #89 Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

Copilot

Pull request overview

Adds a user-facing hint to lint task failures to promote the mise run fix autofix workflow, while suppressing the hint during autofix runs.

Changes:

Add an EXIT trap to super-linter.sh to print a mise run fix hint on failure and clean up the temp env file.
Add the same mise run fix hint to renovate-deps.py when failing in non-autofix mode.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
tasks/lint/super-linter.sh	Adds EXIT trap cleanup + prints a `mise run fix` hint when the task exits non-zero (except AUTOFIX).
tasks/lint/renovate-deps.py	Prints the `mise run fix` hint in non-autofix failure paths.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Guard rm -f with non-empty check for _FILTERED_ENV_FILE - Only show 'mise run fix' hint when linter actually ran, not on config/runtime failures (missing env vars, container pull errors) - Fix ruff formatting in renovate-deps.py Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

Super-Linter applies its own .ruff.toml with line-length=120. Local ruff defaults to 88, causing format mismatches. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

Split hint strings to stay under pylint's 100-char limit. Add fmt:skip to prevent ruff from rejoining them at 120. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

Ruff covers the same rules as pylint and isort, and was already used for formatting. Having both caused line-length conflicts (pylint: 100, ruff: 120). Disable pylint and isort, enable ruff lint autofix, and remove fmt:skip workarounds. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

zeitlinger · 2026-03-06T10:19:10Z

@martincostello Could you review this when you get a chance? All CI green except a cancelled TruffleHog scan.

zeitlinger · 2026-03-06T10:19:25Z

/easycla

🤖 I have created a release *beep* *boop* --- ## [0.8.0](v0.7.1...v0.8.0) (2026-03-11) ### Features * add native linting mode and version mapping infrastructure ([#93](#93)) ([24b06da](24b06da)) ### Bug Fixes * add 'mise run fix' hint to lint failure output ([#90](#90)) ([5b4ad5d](5b4ad5d)) * improve link checker reliability against GitHub rate limiting ([#95](#95)) ([7a5282d](7a5282d)) * remap same-repo GitHub URLs to local file paths ([#100](#100)) ([b4feadd](b4feadd)) --- > [!IMPORTANT] > Close and reopen this PR to trigger CI checks. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

## flint v0.20.0 — Rust rewrite flint has been rewritten from scratch in Rust. The bash + Docker stack is replaced by a fast, cross-platform native binary with no container dependency. ### Highlights - **Native binary** — no Docker, no bash wrappers; runs anywhere mise can install a Rust crate - **Parallel linting** — all checks run concurrently - **Diff-aware** — only checks files changed since the merge base by default (`--full` for everything) - **`flint update`** — migrates obsolete `mise.toml` tool keys automatically (e.g. `ubi:` → `github:`, `npm:markdownlint-cli` → `npm:markdownlint-cli2`) - **`flint hook install`** — installs a pre-commit hook without any mise task knowledge - **New linters**: `gofmt`, `google-java-format`, `ktlint`, `dotnet-format`, `markdownlint-cli2`, `xmllint` (via `cargo:xmloxide`), `license-header` (pure-Rust, no binary) - **Windows support** — ktlint self-executing JAR handled via explicit `java -jar` invocation ### Migration See [AGENTS-V2.md](https://github.com/grafana/flint/blob/main/AGENTS-V2.md) and [README.md](https://github.com/grafana/flint/blob/main/README.md) for full setup instructions. Quick reference for existing consumers: ```toml [tools] # While installing from source (pre-crates.io release): "cargo:https://github.com/grafana/flint" = "branch:main" [env] FLINT_CONFIG_DIR = ".github/config" [tasks.lint] run = "flint run" [tasks."lint:fix"] run = "flint run --fix" ``` Remove: `lint:super-linter`, `lint:links`, `lint:renovate-deps`, `setup:native-lint-tools`, `setup:pre-commit-hook` tasks. Run `flint update` to auto-migrate any obsolete tool keys. > [!NOTE] > The changelog below includes entries from the legacy v1 bash era — see [README-V1.md](https://github.com/grafana/flint/blob/main/README-V1.md) for v1 docs. --- ## [0.20.0](flint-v0.19.0...flint-v0.20.0) (2026-04-13) ### Features * add flint v2 Rust binary ([#139](#139)) ([19f2b25](19f2b25)) * add native linting mode and version mapping infrastructure ([#93](#93)) ([24b06da](24b06da)) * add Renovate shareable preset for consuming repos ([#17](#17)) ([8a06590](8a06590)) * consolidate link checking and add autofix flags ([#7](#7)) ([086a5e9](086a5e9)) * flint update command, explicit JAR flag, v0.20.0 ([#146](#146)) ([b43bf52](b43bf52)) * handle line-number anchors and issue comments globally ([#56](#56)) ([cf751df](cf751df)) * **links:** add GitHub URL remaps for line-number and fragment anchors ([#28](#28)) ([5b59065](5b59065)) * **links:** auto-remap base-branch GitHub URLs to PR branch ([#18](#18)) ([dd6cc61](dd6cc61)) * **renovate:** support SHA-pinned URLs in Renovate preset ([#21](#21)) ([4fd1f28](4fd1f28)) * **super-linter:** default to slim image ([#24](#24)) ([c8eeab8](c8eeab8)) * support NATIVE env var for container-free linting ([#107](#107)) ([0a8193d](0a8193d)) ### Bug Fixes * activate mise environment in native lint mode ([#123](#123)) ([d0fec45](d0fec45)) * add 'mise run fix' hint to lint failure output ([#90](#90)) ([5b4ad5d](5b4ad5d)) * decouple version mapping generation from pinned super-linter version ([#112](#112)) ([5370e77](5370e77)) * **deps:** update rust crate crossterm to 0.29 ([#156](#156)) ([c59ae3e](c59ae3e)) * **deps:** update rust crate similar to v3 ([#160](#160)) ([684be4e](684be4e)) * **deps:** update rust crate toml to v1 ([#161](#161)) ([3aae614](3aae614)) * **deps:** update rust crate toml_edit to 0.25 ([#158](#158)) ([42d9efd](42d9efd)) * exclude GitHub compare links from lychee checks ([#10](#10)) ([e714608](e714608)) * fail native lint when enabled tools are missing ([#111](#111)) ([163bb6b](163bb6b)) * improve link checker reliability against GitHub rate limiting ([#95](#95)) ([7a5282d](7a5282d)) * include staged files in native lint file list ([#135](#135)) ([34412d6](34412d6)) * **links:** add regex anchors to remap patterns ([#19](#19)) ([2e17348](2e17348)) * native lint in worktrees, trust toml, use ec binary, drop isort ([#134](#134)) ([8594bba](8594bba)) * **release-please:** fix footer not appearing on release PRs ([#40](#40)) ([d7a55e4](d7a55e4)) * remap same-repo GitHub URLs to local file paths ([#100](#100)) ([b4feadd](b4feadd)) * **renovate-deps:** forward GITHUB_TOKEN as GITHUB_COM_TOKEN ([#132](#132)) ([4d6510b](4d6510b)) * replace broken release-please PR comment with docs ([#12](#12)) ([817b37d](817b37d)) * run shellcheck on .bats files in native mode ([#137](#137)) ([a4fd3f8](a4fd3f8)) * strip Scroll to Text Fragment anchors in link checks ([#86](#86)) ([b630cdf](b630cdf)) * tighten markdownlint config for native mode ([#106](#106)) ([6ef25b2](6ef25b2)) * use remap instead of exclude for issue comment anchors ([#58](#58)) ([656f355](656f355)) --- > [!IMPORTANT] > Close and reopen this PR to trigger CI checks. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 3, 2026 11:33

Copilot started reviewing on behalf of zeitlinger March 3, 2026 11:34 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Comment thread tasks/lint/super-linter.sh Outdated

Comment thread tasks/lint/super-linter.sh Outdated

Comment thread tasks/lint/super-linter.sh

zeitlinger added 5 commits March 5, 2026 13:40

fix: format renovate-deps.py with line-length 120

4f3c626

Super-Linter applies its own .ruff.toml with line-length=120. Local ruff defaults to 88, causing format mismatches. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

fix: satisfy both pylint (max 100) and ruff (max 120)

20d9cb8

Split hint strings to stay under pylint's 100-char limit. Add fmt:skip to prevent ruff from rejoining them at 120. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

fix: sort env keys alphabetically

7d2ee56

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

martincostello approved these changes Mar 10, 2026

View reviewed changes

zeitlinger merged commit 5b4ad5d into main Mar 10, 2026
8 of 11 checks passed

zeitlinger deleted the fix/lint-failure-hint branch March 10, 2026 11:13

github-actions Bot mentioned this pull request Mar 10, 2026

chore(main): release 0.8.0 #96

Merged

github-actions Bot mentioned this pull request Apr 13, 2026

chore(main): release flint 0.20.0 #165

Merged

This was referenced Apr 16, 2026

chore: release v0.20.2 #181

Closed

chore: release v0.20.2 #183

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add 'mise run fix' hint to lint failure output#90

fix: add 'mise run fix' hint to lint failure output#90
zeitlinger merged 6 commits intomainfrom
fix/lint-failure-hint

zeitlinger commented Mar 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zeitlinger commented Mar 6, 2026 •

edited

Loading

Uh oh!

zeitlinger commented Mar 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

zeitlinger commented Mar 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zeitlinger commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zeitlinger commented Mar 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zeitlinger commented Mar 6, 2026 •

edited

Loading