Skip to content

fix: use remap instead of exclude for issue comment anchors#58

Merged
zeitlinger merged 1 commit intomainfrom
global-github-url-handling
Feb 23, 2026
Merged

fix: use remap instead of exclude for issue comment anchors#58
zeitlinger merged 1 commit intomainfrom
global-github-url-handling

Conversation

@zeitlinger
Copy link
Copy Markdown
Member

@zeitlinger zeitlinger commented Feb 23, 2026

Summary

Fixes the lint failure in #41 (release-please PR).

CLI --exclude overrides (rather than merges with) config file excludes in lychee. The --exclude added in #56 for #issuecomment- URLs caused the config file's exclude patterns (like the compare/ URL exclusion) to be ignored.

Fix: switch to --remap which strips the #issuecomment- fragment while still checking the issue/PR page itself.

Test plan

Copilot AI review requested due to automatic review settings February 23, 2026 10:55
Copilot AI reviewed Feb 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a lint failure in the release-please PR (#41) by switching from --exclude to --remap for handling GitHub issue comment anchors. The root cause was that lychee's CLI --exclude overrides (rather than merges with) config file excludes, causing important exclusions like compare/ URLs to be ignored. The solution uses --remap to strip the #issuecomment- fragment while still checking the underlying issue/PR page.

Changes:

  • Switched from --exclude to --remap for issue comment anchor handling to preserve config file exclude patterns
  • Added global GitHub URL remaps for line-number anchors and issue comment anchors that apply to all repositories
  • Updated documentation in README and test file to describe the new global URL handling behavior

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tasks/lint/links.sh Added build_global_github_args() function to handle line-number and issue comment anchors globally using --remap; renamed remap_args to extra_args to reflect broader scope
tests/test-links.md Added test cases for external repository line-number anchors and issue comment anchors
README.md Added documentation section explaining global GitHub URL handling for line-number and issue comment anchors
.github/config/lychee.toml Removed redundant remap rule (now handled by script) with explanatory comment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test-links.md Outdated
<!-- editorconfig-checker-enable -->
- [lychee main.rs#L1](https://github.com/lycheeverse/lychee/blob/master/lychee-bin/src/main.rs#L1)

## Issue comment anchors — excluded globally
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section header says "excluded globally" but the implementation actually remaps (strips the fragment) rather than excludes. The issue/PR page is still checked, just without the fragment. This should say "fragment stripped globally" or "remapped globally" to match the actual behavior and be consistent with the line above (line 24) which says "fragment stripped globally".

Suggested change
## Issue comment anchors — excluded globally
## Issue comment anchors — fragment stripped globally

Copilot uses AI. Check for mistakes.
@zeitlinger zeitlinger force-pushed the global-github-url-handling branch from 15799d3 to 3379e77 Compare February 23, 2026 11:36
@zeitlinger
fix: use remap instead of exclude for issue comment anchors
a105071 
CLI --exclude overrides (rather than merges with) config file
excludes in lychee. Switch to --remap which strips the
#issuecomment fragment while still checking the issue/PR page.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger zeitlinger force-pushed the global-github-url-handling branch from 3379e77 to a105071 Compare February 23, 2026 11:40
@zeitlinger
Copy link
Copy Markdown
Member Author

zeitlinger commented Feb 23, 2026

Addressed Copilot's review comment: updated test header from "excluded globally" to "fragment stripped globally" to match the actual remap behavior.

@zeitlinger zeitlinger merged commit 656f355 into main Feb 23, 2026
8 checks passed
@zeitlinger zeitlinger deleted the global-github-url-handling branch February 23, 2026 11:41
@github-actions github-actions Bot mentioned this pull request Feb 23, 2026
Merged
zeitlinger pushed a commit that referenced this pull request Feb 23, 2026
@github-actions
chore(main): release 0.7.0 (#41)
8822bdc 
🤖 I have created a release *beep* *boop*
---


## [0.7.0](v0.6.0...v0.7.0)
(2026-02-23)


### Features

* handle line-number anchors and issue comments globally
([#56](#56))
([cf751df](cf751df))


### Bug Fixes

* **release-please:** fix footer not appearing on release PRs
([#40](#40))
([d7a55e4](d7a55e4))
* use remap instead of exclude for issue comment anchors
([#58](#58))
([656f355](656f355))

---
> [!IMPORTANT]
> Close and reopen this PR to trigger CI checks.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions Bot mentioned this pull request Apr 13, 2026
Merged
zeitlinger pushed a commit that referenced this pull request Apr 13, 2026
@github-actions
chore(main): release flint 0.20.0 (#165)
d5e1401 
## flint v0.20.0 — Rust rewrite

flint has been rewritten from scratch in Rust. The bash + Docker stack
is replaced by a fast, cross-platform native binary with no container
dependency.

### Highlights

- **Native binary** — no Docker, no bash wrappers; runs anywhere mise
can install a Rust crate
- **Parallel linting** — all checks run concurrently
- **Diff-aware** — only checks files changed since the merge base by
default (`--full` for everything)
- **`flint update`** — migrates obsolete `mise.toml` tool keys
automatically (e.g. `ubi:` → `github:`, `npm:markdownlint-cli` →
`npm:markdownlint-cli2`)
- **`flint hook install`** — installs a pre-commit hook without any mise
task knowledge
- **New linters**: `gofmt`, `google-java-format`, `ktlint`,
`dotnet-format`, `markdownlint-cli2`, `xmllint` (via `cargo:xmloxide`),
`license-header` (pure-Rust, no binary)
- **Windows support** — ktlint self-executing JAR handled via explicit
`java -jar` invocation

### Migration

See
[AGENTS-V2.md](https://github.com/grafana/flint/blob/main/AGENTS-V2.md)
and [README.md](https://github.com/grafana/flint/blob/main/README.md)
for full setup instructions.

Quick reference for existing consumers:

```toml
[tools]
# While installing from source (pre-crates.io release):
"cargo:https://github.com/grafana/flint" = "branch:main"

[env]
FLINT_CONFIG_DIR = ".github/config"

[tasks.lint]
run = "flint run"

[tasks."lint:fix"]
run = "flint run --fix"
```

Remove: `lint:super-linter`, `lint:links`, `lint:renovate-deps`,
`setup:native-lint-tools`, `setup:pre-commit-hook` tasks. Run `flint
update` to auto-migrate any obsolete tool keys.

> [!NOTE]
> The changelog below includes entries from the legacy v1 bash era — see
[README-V1.md](https://github.com/grafana/flint/blob/main/README-V1.md)
for v1 docs.

---

##
[0.20.0](flint-v0.19.0...flint-v0.20.0)
(2026-04-13)


### Features

* add flint v2 Rust binary
([#139](#139))
([19f2b25](19f2b25))
* add native linting mode and version mapping infrastructure
([#93](#93))
([24b06da](24b06da))
* add Renovate shareable preset for consuming repos
([#17](#17))
([8a06590](8a06590))
* consolidate link checking and add autofix flags
([#7](#7))
([086a5e9](086a5e9))
* flint update command, explicit JAR flag, v0.20.0
([#146](#146))
([b43bf52](b43bf52))
* handle line-number anchors and issue comments globally
([#56](#56))
([cf751df](cf751df))
* **links:** add GitHub URL remaps for line-number and fragment anchors
([#28](#28))
([5b59065](5b59065))
* **links:** auto-remap base-branch GitHub URLs to PR branch
([#18](#18))
([dd6cc61](dd6cc61))
* **renovate:** support SHA-pinned URLs in Renovate preset
([#21](#21))
([4fd1f28](4fd1f28))
* **super-linter:** default to slim image
([#24](#24))
([c8eeab8](c8eeab8))
* support NATIVE env var for container-free linting
([#107](#107))
([0a8193d](0a8193d))


### Bug Fixes

* activate mise environment in native lint mode
([#123](#123))
([d0fec45](d0fec45))
* add 'mise run fix' hint to lint failure output
([#90](#90))
([5b4ad5d](5b4ad5d))
* decouple version mapping generation from pinned super-linter version
([#112](#112))
([5370e77](5370e77))
* **deps:** update rust crate crossterm to 0.29
([#156](#156))
([c59ae3e](c59ae3e))
* **deps:** update rust crate similar to v3
([#160](#160))
([684be4e](684be4e))
* **deps:** update rust crate toml to v1
([#161](#161))
([3aae614](3aae614))
* **deps:** update rust crate toml_edit to 0.25
([#158](#158))
([42d9efd](42d9efd))
* exclude GitHub compare links from lychee checks
([#10](#10))
([e714608](e714608))
* fail native lint when enabled tools are missing
([#111](#111))
([163bb6b](163bb6b))
* improve link checker reliability against GitHub rate limiting
([#95](#95))
([7a5282d](7a5282d))
* include staged files in native lint file list
([#135](#135))
([34412d6](34412d6))
* **links:** add regex anchors to remap patterns
([#19](#19))
([2e17348](2e17348))
* native lint in worktrees, trust toml, use ec binary, drop isort
([#134](#134))
([8594bba](8594bba))
* **release-please:** fix footer not appearing on release PRs
([#40](#40))
([d7a55e4](d7a55e4))
* remap same-repo GitHub URLs to local file paths
([#100](#100))
([b4feadd](b4feadd))
* **renovate-deps:** forward GITHUB_TOKEN as GITHUB_COM_TOKEN
([#132](#132))
([4d6510b](4d6510b))
* replace broken release-please PR comment with docs
([#12](#12))
([817b37d](817b37d))
* run shellcheck on .bats files in native mode
([#137](#137))
([a4fd3f8](a4fd3f8))
* strip Scroll to Text Fragment anchors in link checks
([#86](#86))
([b630cdf](b630cdf))
* tighten markdownlint config for native mode
([#106](#106))
([6ef25b2](6ef25b2))
* use remap instead of exclude for issue comment anchors
([#58](#58))
([656f355](656f355))

---
> [!IMPORTANT]
> Close and reopen this PR to trigger CI checks.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Apr 16, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zeitlinger