fix: remove stale exclude_paths init placeholder#211
Merged
zeitlinger merged 3 commits intomainfrom Apr 23, 2026
Merged
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
zeitlinger
force-pushed
the
codex/remove-stale-exclude-paths
branch
from
fe182fb to
0de0b1b
Compare
Member
Author
|
Updated the branch to also remove the stale |
martincostello
approved these changes
Apr 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a stale, misleading exclude_paths placeholder from generated flint.toml output and updates the associated unit/e2e snapshots to reflect the supported config key ([settings].exclude).
Changes:
- Removed
# exclude_paths = []from the generatedflint.tomlskeleton. - Updated the init unit test assertion to stop expecting
exclude_paths. - Updated e2e/init snapshots to match the new
flint.tomlcontent.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/init/generation.rs |
Stops emitting the unsupported exclude_paths placeholder in generated config. |
src/init/mod.rs |
Updates init unit test to no longer assert the removed placeholder. |
tests/cases/general/init-rust/test.toml |
Updates init snapshot expectation for generated .github/config/flint.toml. |
tests/cases/general/init-idempotent/files/.github/config/flint.toml |
Updates idempotency fixture to match the new generated skeleton. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Merged
zeitlinger
pushed a commit
that referenced
this pull request
Apr 23, 2026
### Added - group linter renovate updates ([#209](#209)) ### Fixed - expand baseline guards for config and flint changes ([#215](#215)) - remove stale exclude_paths init placeholder ([#211](#211)) - baseline lint coverage changes ([#214](#214)) - align biome init and formatter ownership ([#205](#205)) ### Other - *(deps)* update dependency npm:renovate to v43.133.0 ([#216](#216)) - *(deps)* update dependency npm:renovate to v43.132.2 ([#212](#212)) - *(deps)* update taiki-e/install-action digest to 5f57d6c ([#204](#204)) - clarify that flint init works with existing mise.toml ([#208](#208)) - guard against overlapping fixer ownership ([#206](#206)) > [!IMPORTANT] > Close and reopen this PR to trigger CI checks. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Removed the commented
exclude_pathssetting from generatedflint.tomloutput and updated the init unit test plus e2e snapshot.Why
exclude_pathsis not a supported runtime config key. The actual setting is[settings].exclude, so the generated placeholder was misleading.Validation
cargo test init::tests::generate_flint_toml_writes_skeletonFLINT_CASES=general/init-rust cargo test casesmise run lint:fixmise run lint:fixsuccessfullyNote:
miseemitted a local fake-asdf permission warning during lint runs, but the task exited successfully.